[Patch] Disable text mode translation in ada for Cygwin

[Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 1220 bytes --]

Text mode translation should not be done for Cygwin, especially since it does not
support unicode setmode calls. This also fixes ada builds for Cygwin.

OK for trunk?

gcc/ada/ChangeLog:
	* sysdep.c (__gnat_set_binary_mode, __gnat_set_text_mode,
	__gnat_set_mode): Disable text mode translation, Cygwin should
	follow *Nix behavior. This also fixes build failures on Cywgin.

diff --git a/gcc/ada/sysdep.c b/gcc/ada/sysdep.c
index 465007e..aeaed6d 100644
--- a/gcc/ada/sysdep.c
+++ b/gcc/ada/sysdep.c
@@ -128,15 +128,15 @@ extern struct tm *localtime_r(const time_t *, struct tm *);

 #if defined (WINNT) || defined (__CYGWIN__)

+#if defined (__CYGWIN__)
+const char __gnat_text_translation_required = 0;
+void __gnat_set_binary_mode (int handle) {}
+void __gnat_set_text_mode (int handle) {}
+void __gnat_set_mode(int handle, int mode) {}
+#else
 const char __gnat_text_translation_required = 1;

-#ifdef __CYGWIN__
-#define WIN_SETMODE setmode
-#include <io.h>
-#else
 #define WIN_SETMODE _setmode
-#endif
-
 void
 __gnat_set_binary_mode (int handle)
 {
@@ -172,6 +172,8 @@ __gnat_set_mode (int handle, int mode)
  }
 }

+#endif __CYGWIN__
+
 #ifdef __CYGWIN__

 char *


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[Arnaud Charlet]

> Text mode translation should not be done for Cygwin, especially since it
> does not
> support unicode setmode calls. This also fixes ada builds for Cygwin.
> 
> OK for trunk?

OK, thanks.

> gcc/ada/ChangeLog:
> 	* sysdep.c (__gnat_set_binary_mode, __gnat_set_text_mode,
> 	__gnat_set_mode): Disable text mode translation, Cygwin should
> 	follow *Nix behavior. This also fixes build failures on Cywgin.

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 333 bytes --]

On 5/26/2016 21:55, Arnaud Charlet wrote:
>> Text mode translation should not be done for Cygwin, especially since it
>> does not
>> support unicode setmode calls. This also fixes ada builds for Cygwin.
>>
>> OK for trunk?
> 
> OK, thanks.
> 

Can someone please commit this? I don't have SVN write access.

Thanks.



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 395 bytes --]

On 5/27/2016 06:25, JonY wrote:
> On 5/26/2016 21:55, Arnaud Charlet wrote:
>>> Text mode translation should not be done for Cygwin, especially since it
>>> does not
>>> support unicode setmode calls. This also fixes ada builds for Cygwin.
>>>
>>> OK for trunk?
>>
>> OK, thanks.
>>
> 
> Can someone please commit this? I don't have SVN write access.
> 
> Thanks.
> 

Ping?



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 505 bytes --]

On 6/1/2016 18:27, JonY wrote:
> On 5/27/2016 06:25, JonY wrote:
>> On 5/26/2016 21:55, Arnaud Charlet wrote:
>>>> Text mode translation should not be done for Cygwin, especially since it
>>>> does not
>>>> support unicode setmode calls. This also fixes ada builds for Cygwin.
>>>>
>>>> OK for trunk?
>>>
>>> OK, thanks.
>>>
>>
>> Can someone please commit this? I don't have SVN write access.
>>
>> Thanks.
>>
> 
> Ping?
> 
> 

ping2? Is there a dedicated list for ADA patches?



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[Arnaud Charlet]

>>>>> Text mode translation should not be done for Cygwin, especially since it
>>>>> does not
>>>>> support unicode setmode calls. This also fixes ada builds for Cygwin.
>>>>> 
>>>>> OK for trunk?
>>>> 
>>>> OK, thanks.
>>> 
>>> Can someone please commit this? I don't have SVN write access.
>>> 
>>> Thanks.
>> 
>> Ping?
> 
> ping2? Is there a dedicated list for ADA patches?

This list is for submitting patches, which you have done, it is not really about pinging for commits, which should preferably be done by the submitter, after proper testing.

I do not have a setup to test cygwin changes, so cannot do it for you.

Arno

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 441 bytes --]

On 7/1/2016 20:00, Arnaud Charlet wrote:
>> 
>> ping2? Is there a dedicated list for ADA patches?
> 
> This list is for submitting patches, which you have done, it is not
> really about pinging for commits, which should preferably be done by
> the submitter, after proper testing.
> 
> I do not have a setup to test cygwin changes, so cannot do it for
> you.
> 

I have already tested it on Cygwin before submitting the test.


[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 225 bytes --]

On 5/26/2016 20:36, JonY wrote:
> Text mode translation should not be done for Cygwin, especially since it does not
> support unicode setmode calls. This also fixes ada builds for Cygwin.
> 
> OK for trunk?

Ping?



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[Arnaud Charlet]

> > Text mode translation should not be done for Cygwin, especially since it
> > does not
> > support unicode setmode calls. This also fixes ada builds for Cygwin.
> > 
> > OK for trunk?
> 
> Ping?

Can you send the link to your original submission for easy retrieval?

Arno

Re: [Patch] Disable text mode translation in ada for Cygwin

[JonY]

[-- Attachment #1: Type: text/plain, Size: 412 bytes --]

On 8/19/2016 20:49, Arnaud Charlet wrote:
>>> Text mode translation should not be done for Cygwin, especially since it
>>> does not
>>> support unicode setmode calls. This also fixes ada builds for Cygwin.
>>>
>>> OK for trunk?
>>
>> Ping?
> 
> Can you send the link to your original submission for easy retrieval?
> 
> Arno
> 

Bottom of the page:
https://patchwork.ozlabs.org/patch/626650/



[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 801 bytes --]

Re: [Patch] Disable text mode translation in ada for Cygwin

[Gerald Pfeifer]

On Fri, 19 Aug 2016, Arnaud Charlet wrote:
>>> Text mode translation should not be done for Cygwin, especially since 
>>> it does not support unicode setmode calls. This also fixes ada builds 
>>> for Cygwin.
>> Ping?
> Can you send the link to your original submission for easy retrieval?

I'm not JonY, but here is the link:

  https://gcc.gnu.org/ml/gcc-patches/2016-05/msg02088.html

Gerald

Re: [Patch] Disable text mode translation in ada for Cygwin

[Arnaud Charlet]

Patch is OK