From: Segher Boessenkool <segher@kernel.crashing.org>
To: Steven Bosscher <stevenb.gcc@gmail.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Paolo Bonzini <bonzini@gnu.org>,
Seongbae Park <seongbae.park@gmail.com>,
Kenneth Zadeck <zadeck@naturalbridge.com>
Subject: Re: [PATCH] df: Keep return address register undefined until epilogue_completed
Date: Mon, 29 Aug 2016 20:41:00 -0000 [thread overview]
Message-ID: <20160829204121.GB22842@gate.crashing.org> (raw)
In-Reply-To: <CABu31nNY=8qaWgdtVA2Mc9J+zjm5HL+J--XNVKU4Zxx6h9QNyA@mail.gmail.com>
On Mon, Aug 29, 2016 at 10:19:25PM +0200, Steven Bosscher wrote:
> On Mon, Aug 29, 2016 at 6:50 PM, Segher Boessenkool wrote:
> > This patch changes that so that that def is only added after
> > epilogue_completed.
> ...
> > Does this work on all other targets?
>
> Guessing: not for targets where INCOMING_RETURN_ADDR_RTX is the stack register?
> That'd be at least h8300, rl78, and rx.
The stack pointer is always added (earlier in this function):
/* The always important stack pointer. */
bitmap_set_bit (entry_block_defs, STACK_POINTER_REGNUM);
so that isn't it.
History suggests it was a fix (or workaround) for a problem on ia64,
but I might well have that wrong.
Segher
next prev parent reply other threads:[~2016-08-29 20:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-29 16:50 Segher Boessenkool
2016-08-29 20:20 ` Steven Bosscher
2016-08-29 20:41 ` Segher Boessenkool [this message]
2016-09-09 22:51 ` Jeff Law
2016-09-09 22:35 ` Jeff Law
2016-09-09 22:42 ` Jeff Law
2016-09-10 8:03 ` Segher Boessenkool
2016-09-12 16:33 ` Jeff Law
2016-09-14 12:46 ` Segher Boessenkool
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160829204121.GB22842@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=bonzini@gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=seongbae.park@gmail.com \
--cc=stevenb.gcc@gmail.com \
--cc=zadeck@naturalbridge.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).