From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-435117-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 515 invoked by alias); 2 Sep 2016 12:31:45 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 505 invoked by uid 89); 2 Sep 2016 12:31:44 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-2.3 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=honza, Honza
X-HELO: nikam.ms.mff.cuni.cz
Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 02 Sep 2016 12:31:42 +0000
Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202)	id 6712A5423D8; Fri,  2 Sep 2016 14:31:38 +0200 (CEST)
Date: Fri, 02 Sep 2016 12:31:00 -0000
From: Jan Hubicka <hubicka@ucw.cz>
To: Kugan Vivekanandarajah <kugan.vivekanandarajah@linaro.org>
Cc: Jan Hubicka <hubicka@ucw.cz>,	"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,	Richard Biener <richard.guenther@gmail.com>
Subject: Re: [RFC][IPA-VRP] Add support for IPA VRP in ipa-cp/ipa-prop
Message-ID: <20160902123137.GC57001@kam.mff.cuni.cz>
References: <57886949.8010300@linaro.org> <57886A2A.4070703@linaro.org> <57886ABA.2060404@linaro.org> <20160715122309.glir5vk5ttwoagdp@virgil.suse.cz> <578DE340.4010904@linaro.org> <578E9B16.2080100@linaro.org> <20160721125416.GA23760@kam.mff.cuni.cz> <CAELXzTPZibtMvYexaFnjchBkn1np45UxGaDiBu_yXbYH7ewDYA@mail.gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <CAELXzTPZibtMvYexaFnjchBkn1np45UxGaDiBu_yXbYH7ewDYA@mail.gmail.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
X-SW-Source: 2016-09/txt/msg00080.txt.bz2

> Hi Honza,
> 
> Here is a re-based version which also addresses the review comments.
> 
> Do you mean the following, I was following other implementations.
> 
> @@ -2264,6 +2430,11 @@ propagate_constants_accross_call (struct
> cgraph_edge *cs)
>         &dest_plats->bits_lattice);
>    ret |= propagate_aggs_accross_jump_function (cs, jump_func,
>         dest_plats);
> +  if (opt_for_fn (callee->decl, flag_ipa_vrp))
> +    ret |= propagate_vr_accross_jump_function (cs,
> +       jump_func, dest_plats);
> +  else
> +    ret |= dest_plats->m_value_range.set_to_bottom ();

yes, that looks fine.

Path is OK, thanks!

Honza