From: Jakub Jelinek <jakub@redhat.com>
To: Kirill Yukhin <kirill.yukhin@gmail.com>
Cc: gcc-patches@gcc.gnu.org, hubicka@ucw.cz
Subject: Re: [PATCH, IPA] Check pointer for 0 before use in `get_odr_type`
Date: Fri, 02 Sep 2016 21:04:00 -0000 [thread overview]
Message-ID: <20160902205648.GN14857@tucnak.redhat.com> (raw)
In-Reply-To: <394ceee5-dfc2-f9a7-c534-7a09f222c2ab@gmail.com>
On Fri, Sep 02, 2016 at 11:53:01PM +0300, Kirill Yukhin wrote:
> Hello,
> Looks like `get_odr_type ()` contains code which dereferences
> pointer before check it for zero. I moved the line under the check.
>
> Bootstrap/regtest on x?86|x86_64 in progress.
>
> Is it ok for trunk if pass?
>
> gcc/
> * gcc/ipa-devirt.c (get_odr_type): Check odr_types_ptr for
> zero before dereferencing it.
I've already tested/posted
http://gcc.gnu.org/ml/gcc-patches/2016-09/msg00089.html
for this.
Jakub
next prev parent reply other threads:[~2016-09-02 20:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 20:54 Kirill Yukhin
2016-09-02 21:04 ` Jakub Jelinek [this message]
2016-09-02 21:06 ` Kirill Yukhin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160902205648.GN14857@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=hubicka@ucw.cz \
--cc=kirill.yukhin@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).