From: Jonathan Wakely <jwakely@redhat.com>
To: Matthew Wahab <matthew.wahab@foss.arm.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite.
Date: Tue, 06 Sep 2016 10:16:00 -0000 [thread overview]
Message-ID: <20160906101528.GA32255@redhat.com> (raw)
In-Reply-To: <57C97BF8.5090601@foss.arm.com>
On 02/09/16 14:17 +0100, Matthew Wahab wrote:
>Hello,
>
>Tests in the libstdc++-v3 testsuite were recently changed to use { dg-do
>.. { target c++11 } } instead of using a dg-options to set -std
>(https://gcc.gnu.org/ml/libstdc++/2016-08/msg00102.html). As a
>consequence, several tests were left with directive lists that had
>dg-require preceding dg-do. This meant that some tests were run when
>they should have been skipped as unsupported. In particular, most of the
>23_algorithms/*/complexity.cc tests became FAIL on aarch64-none-elf
>
>This patch adjusts the tests so that the dg-requires come after the
>dg-do directives. The makes the tests that were previously
>FAIL/UNRESOLVED become UNSUPPORTED. It also makes UNSUPPORTED some tests
>that were PASS.
>
>The tests that move from FAIL/UNRESOLVED to UNSUPPORTED:
>
>- 22_locale/locale/cons/unicode.cc.
>- 25_algorithms/{pop_heap,push_heap,sort_heap}/complexity.c.
>
From PASS to UNSUPPORTED:
>
>- 23_containers/*/debug/60499.c
>- 23_containers/vector/debug/52433.c
>
>Tested by running the testsuite for cross-compiled aarch64-none-elf.
>
>Ok for trunk?
Yes, thanks for cleaning this up.
next prev parent reply other threads:[~2016-09-06 10:15 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 13:18 Matthew Wahab
2016-09-06 10:16 ` Jonathan Wakely [this message]
2016-09-14 13:21 ` Christophe Lyon
2016-09-14 13:36 ` Jonathan Wakely
2016-09-14 13:41 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160906101528.GA32255@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=matthew.wahab@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).