From: Jakub Jelinek <jakub@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>,
Jason Merrill <jason@redhat.com>,
Joseph Myers <joseph@codesourcery.com>
Subject: Re: C/C++ PATCH to implement -Wpointer-compare warning (PR c++/64767)
Date: Sat, 10 Sep 2016 15:13:00 -0000 [thread overview]
Message-ID: <20160910150751.GK2920@laptop.zalov.cz> (raw)
In-Reply-To: <20160910145843.GJ19950@redhat.com>
Hi!
Just a minor nit:
On Sat, Sep 10, 2016 at 04:58:43PM +0200, Marek Polacek wrote:
> Spurred by the recent <http://www.viva64.com/en/b/0425/> findings, I decided to
> implement a warning that warns when a pointer is compared with a zero character
> literal (constant), because this isn't likely to be intended. So e.g.
> @@ -4777,6 +4778,7 @@ cp_parser_primary_expression (cp_parser *parser,
> case CPP_CHAR32:
> case CPP_WCHAR:
> case CPP_UTF8CHAR:
> + char_literal_p = true;
> case CPP_NUMBER:
> case CPP_PREPARSED_EXPR:
> if (TREE_CODE (token->u.value) == USERDEF_LITERAL)
No /* FALLTHRU */ ?
Jakub
next prev parent reply other threads:[~2016-09-10 15:08 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 15:06 Marek Polacek
2016-09-10 15:13 ` Jakub Jelinek [this message]
2016-09-10 15:48 ` Marek Polacek
2016-09-14 5:56 ` Jason Merrill
2016-09-15 12:31 ` Marek Polacek
2016-09-19 19:51 ` Jason Merrill
2016-09-21 19:55 ` Jason Merrill
2016-09-23 13:29 ` Marek Polacek
2016-09-23 14:37 ` Jason Merrill
2016-09-30 16:52 ` Marek Polacek
2016-09-30 17:22 ` Martin Sebor
2016-09-30 19:52 ` Martin Sebor
2016-09-30 20:02 ` Marek Polacek
2016-09-30 22:16 ` Martin Sebor
2016-09-30 22:16 ` Jason Merrill
2016-10-01 14:41 ` Marek Polacek
2016-10-02 18:43 ` Jason Merrill
2017-01-04 6:56 ` Eric Gallager
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160910150751.GK2920@laptop.zalov.cz \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).