From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 120988 invoked by alias); 13 Sep 2016 11:03:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 119615 invoked by uid 89); 13 Sep 2016 11:03:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=remind, H*r:8.14.1, five X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 13 Sep 2016 11:03:53 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u8DB3o2P005687; Tue, 13 Sep 2016 06:03:50 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id u8DB3ngD005686; Tue, 13 Sep 2016 06:03:49 -0500 Date: Tue, 13 Sep 2016 11:11:00 -0000 From: Segher Boessenkool To: Bernd Schmidt Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/3] Put a TARGET_LRA_P into every target Message-ID: <20160913110349.GA18438@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00710.txt.bz2 On Tue, Sep 13, 2016 at 12:26:04PM +0200, Bernd Schmidt wrote: > On 09/13/2016 12:22 AM, Segher Boessenkool wrote: > >This patch adds a TARGET_LRA_P (defined to hook_bool_void_false) to > >every target that didn't yet override the hook. No functional change. > > This patch series makes very little sense to me. Adding 35 new instances > of a hook definition so you can delete four others? No, the purpose is to default to LRA instead of reload. Everything should switch to LRA eventually, so over time we need to define the macro in fewer and fewer targets, until one day whatever remains can all be ripped out. Yes, many targets need the hook definition after this series; that should stick out like a sore thumb, help to remind people to change their target to use LRA (not a huge amount of work for most, although it can get tricky). And all new ports should use LRA, so it should be the default. Wrt "delete only four"... There are five or six or so more that use LRA, but those can all be switched to use old reload instead. Some day that will be turned off, too. Segher