public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Segher Boessenkool <segher@kernel.crashing.org>
To: Jeff Law <law@redhat.com>
Cc: gcc-patches@gcc.gnu.org
Subject: Re: [PATCH 1/3] Put a TARGET_LRA_P into every target
Date: Wed, 14 Sep 2016 11:06:00 -0000	[thread overview]
Message-ID: <20160914103510.GA24835@gate.crashing.org> (raw)
In-Reply-To: <f203dcf0-53b0-40ef-2267-4282704ba37e@redhat.com>

On Tue, Sep 13, 2016 at 02:38:54PM -0600, Jeff Law wrote:
> I believe a doc update of some kind is in order.  With the doc update 
> the entire series is OK.

Good catch, thanks.  My tests finished, all results identical.  I'll add
the following patch for the doc update (I hope the wording is strong enough).

Thanks,


Segher


2016-09-14  Segher Boessenkool  <segher@kernel.crashing.org>

	* target.def (lra_p): Change commentary (for the manual) for the
	new default.
	* doc/tm.texi: Regenerate.

---
 gcc/doc/tm.texi | 2 +-
 gcc/target.def  | 4 ++--
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi
index dc5bcd6..0ca00d2 100644
--- a/gcc/doc/tm.texi
+++ b/gcc/doc/tm.texi
@@ -2861,7 +2861,7 @@ A target hook which can change allocno class for given pseudo from
 @end deftypefn
 
 @deftypefn {Target Hook} bool TARGET_LRA_P (void)
-A target hook which returns true if we use LRA instead of reload pass.    The default version of this target hook returns always false, but new  ports should use LRA.
+A target hook which returns true if we use LRA instead of reload pass.    The default version of this target hook returns always true.  New ports  should use LRA, and existing ports are encouraged to convert.
 @end deftypefn
 
 @deftypefn {Target Hook} int TARGET_REGISTER_PRIORITY (int)
diff --git a/gcc/target.def b/gcc/target.def
index 8509e7d..a4e4cbb 100644
--- a/gcc/target.def
+++ b/gcc/target.def
@@ -4929,8 +4929,8 @@ DEFHOOK
 (lra_p,
  "A target hook which returns true if we use LRA instead of reload pass.\
   \
-  The default version of this target hook returns always false, but new\
-  ports should use LRA.",
+  The default version of this target hook returns always true.  New ports\
+  should use LRA, and existing ports are encouraged to convert.",
  bool, (void),
  default_lra_p)
 
-- 
1.9.3

  reply	other threads:[~2016-09-14 10:35 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-12 22:22 [PATCH 0/3] Default LRA to "on" Segher Boessenkool
2016-09-12 22:22 ` [PATCH 2/3] Change the default of TARGET_LRA_P to true Segher Boessenkool
2016-09-12 22:22 ` [PATCH 1/3] Put a TARGET_LRA_P into every target Segher Boessenkool
2016-09-13 10:42   ` Bernd Schmidt
2016-09-13 11:11     ` Segher Boessenkool
2016-09-13 14:27       ` Andrew Pinski
2016-09-13 15:53         ` Peter Bergner
2016-09-13 16:08           ` Jeff Law
2016-09-13 17:08             ` Mike Stump
2016-09-13 16:23       ` Joseph Myers
2016-09-13 20:07         ` Segher Boessenkool
2016-09-13 16:02     ` Jeff Law
2016-09-13 20:39   ` Jeff Law
2016-09-14 11:06     ` Segher Boessenkool [this message]
2016-09-14 13:01       ` Peter Bergner
2016-09-14 14:01         ` Segher Boessenkool
2016-09-16 10:39       ` Gerald Pfeifer
2016-09-16 13:34         ` Richard Kenner
2016-09-16 14:35         ` Segher Boessenkool
2016-09-16 19:46           ` Mike Stump
2016-09-19 15:55             ` Segher Boessenkool
2016-09-12 22:28 ` [PATCH 3/3] Delete TARGET_LRA_P from those targets that set it to "true" Segher Boessenkool

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160914103510.GA24835@gate.crashing.org \
    --to=segher@kernel.crashing.org \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=law@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).