From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 107291 invoked by alias); 14 Sep 2016 10:35:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 106803 invoked by uid 89); 14 Sep 2016 10:35:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=encouraged, commentary X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 14 Sep 2016 10:35:14 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id u8EAZBff028460; Wed, 14 Sep 2016 05:35:11 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id u8EAZAXH028459; Wed, 14 Sep 2016 05:35:10 -0500 Date: Wed, 14 Sep 2016 11:06:00 -0000 From: Segher Boessenkool To: Jeff Law Cc: gcc-patches@gcc.gnu.org Subject: Re: [PATCH 1/3] Put a TARGET_LRA_P into every target Message-ID: <20160914103510.GA24835@gate.crashing.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg00800.txt.bz2 On Tue, Sep 13, 2016 at 02:38:54PM -0600, Jeff Law wrote: > I believe a doc update of some kind is in order. With the doc update > the entire series is OK. Good catch, thanks. My tests finished, all results identical. I'll add the following patch for the doc update (I hope the wording is strong enough). Thanks, Segher 2016-09-14 Segher Boessenkool * target.def (lra_p): Change commentary (for the manual) for the new default. * doc/tm.texi: Regenerate. --- gcc/doc/tm.texi | 2 +- gcc/target.def | 4 ++-- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/gcc/doc/tm.texi b/gcc/doc/tm.texi index dc5bcd6..0ca00d2 100644 --- a/gcc/doc/tm.texi +++ b/gcc/doc/tm.texi @@ -2861,7 +2861,7 @@ A target hook which can change allocno class for given pseudo from @end deftypefn @deftypefn {Target Hook} bool TARGET_LRA_P (void) -A target hook which returns true if we use LRA instead of reload pass. The default version of this target hook returns always false, but new ports should use LRA. +A target hook which returns true if we use LRA instead of reload pass. The default version of this target hook returns always true. New ports should use LRA, and existing ports are encouraged to convert. @end deftypefn @deftypefn {Target Hook} int TARGET_REGISTER_PRIORITY (int) diff --git a/gcc/target.def b/gcc/target.def index 8509e7d..a4e4cbb 100644 --- a/gcc/target.def +++ b/gcc/target.def @@ -4929,8 +4929,8 @@ DEFHOOK (lra_p, "A target hook which returns true if we use LRA instead of reload pass.\ \ - The default version of this target hook returns always false, but new\ - ports should use LRA.", + The default version of this target hook returns always true. New ports\ + should use LRA, and existing ports are encouraged to convert.", bool, (void), default_lra_p) -- 1.9.3