From: Jonathan Wakely <jwakely@redhat.com>
To: Christophe Lyon <christophe.lyon@linaro.org>
Cc: Matthew Wahab <matthew.wahab@foss.arm.com>,
gcc-patches <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [libstdc++-v3] Fix dg-require before dg-run directives in testsuite.
Date: Wed, 14 Sep 2016 13:36:00 -0000 [thread overview]
Message-ID: <20160914132749.GH17376@redhat.com> (raw)
In-Reply-To: <CAKdteOZ5ey=xsMe=XO2+JJcMrWBAeVjR2rfR_F7J2tOt7zQQFg@mail.gmail.com>
On 14/09/16 15:17 +0200, Christophe Lyon wrote:
>It seems some tests still have dg-require or dg-skip before dg-do.
>The attached patch fixes that, the only effect is that
>25_algorithms/lower_bound/debug/irreflexive.cc
>is now UNSUPPORTED instead of PASS on arm* and aarch64* targets.
>
>I'm not sure if that's expected. I do see: "#error No debug mode" in the logs.
It's expected, because it has dg-require-debug-mode, so the test
should only run when doing make check-debug, or adding
-D_GLIBCXX_DEBUG to the options used for testing.
It passes in normal mode too, but doesn't test anything very
interesting, so doesn't need to be tested.
>OK for trunk?
Yes, thanks.
next prev parent reply other threads:[~2016-09-14 13:28 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 13:18 Matthew Wahab
2016-09-06 10:16 ` Jonathan Wakely
2016-09-14 13:21 ` Christophe Lyon
2016-09-14 13:36 ` Jonathan Wakely [this message]
2016-09-14 13:41 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914132749.GH17376@redhat.com \
--to=jwakely@redhat.com \
--cc=christophe.lyon@linaro.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=matthew.wahab@foss.arm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).