From: Steve Kargl <sgk@troutmask.apl.washington.edu>
To: Bernd Edlinger <bernd.edlinger@hotmail.de>
Cc: Jeff Law <law@redhat.com>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
Joseph Myers <joseph@codesourcery.com>,
Jason Merrill <jason@redhat.com>,
"fortran@gcc.gnu.org" <fortran@gcc.gnu.org>
Subject: Re: [PATCH, updated] Add a warning for suspicious use of conditional expressions in boolean context
Date: Wed, 14 Sep 2016 17:54:00 -0000 [thread overview]
Message-ID: <20160914174058.GB77830@troutmask.apl.washington.edu> (raw)
In-Reply-To: <AM4PR0701MB2162918E947B0A81ED74C940E4F10@AM4PR0701MB2162.eurprd07.prod.outlook.com>
On Wed, Sep 14, 2016 at 04:10:46PM +0000, Bernd Edlinger wrote:
>
> fortran:
> 2016-09-14 Bernd Edlinger <bernd.edlinger@hotmail.de>
>
> PR c++/77434
> * simplify.c (gfc_simplify_repeat): Fix a warning.
>
> Index: gcc/fortran/simplify.c
> ===================================================================
> --- gcc/fortran/simplify.c (revision 240135)
> +++ gcc/fortran/simplify.c (working copy)
> @@ -5127,7 +5127,7 @@ gfc_simplify_repeat (gfc_expr *e, gfc_expr *n)
>
> if (len ||
> (e->ts.u.cl->length &&
> - mpz_sgn (e->ts.u.cl->length->value.integer)) != 0)
> + mpz_sgn (e->ts.u.cl->length->value.integer) != 0))
> {
> const char *res = gfc_extract_int (n, &ncop);
> gcc_assert (res == NULL);
This part should be committed regardless of the
outcome of a review of the complete patch. The
closing ')' is clearly missed placed.
--
Steve
next prev parent reply other threads:[~2016-09-14 17:41 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-02 18:53 [PATCH] " Bernd Edlinger
2016-09-04 8:45 ` [PATCHv2] " Bernd Edlinger
2016-09-05 11:41 ` Joseph Myers
2016-09-05 14:59 ` Bernd Edlinger
2016-09-05 16:57 ` Joseph Myers
[not found] ` <CAPWdEev7VW5LT47iPh-0EgAJz5ELEnoZ_snLtg-F5ZR+etLimg@mail.gmail.com>
2016-09-05 20:03 ` Bernd Edlinger
2016-09-12 19:40 ` [PATCH] " Jeff Law
2016-09-12 20:02 ` Bernd Edlinger
2016-09-12 20:18 ` Jeff Law
2016-09-12 21:28 ` Bernd Edlinger
2016-09-14 16:14 ` [PATCH, updated] " Bernd Edlinger
2016-09-14 16:50 ` Jason Merrill
2016-09-14 17:41 ` Bernd Edlinger
2016-09-14 19:04 ` Jason Merrill
[not found] ` <AM4PR0701MB2162B5B8246F8A10B4B6E42CE4F10@AM4PR0701MB2162.eurprd07.prod.outlook.com>
2016-09-14 20:17 ` [PATCHv3] " Bernd Edlinger
2016-09-15 15:52 ` [PATCH, updated] " Jeff Law
2016-09-15 16:20 ` Bernd Edlinger
2016-09-15 16:36 ` Jeff Law
2016-09-15 16:51 ` Bernd Edlinger
2016-09-15 19:21 ` Joseph Myers
2016-09-15 20:34 ` Jason Merrill
2016-09-15 20:45 ` Bernd Edlinger
2016-09-14 17:54 ` Steve Kargl [this message]
2016-09-14 17:56 ` Bernd Edlinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160914174058.GB77830@troutmask.apl.washington.edu \
--to=sgk@troutmask.apl.washington.edu \
--cc=bernd.edlinger@hotmail.de \
--cc=fortran@gcc.gnu.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=joseph@codesourcery.com \
--cc=kargl@uw.edu \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).