From: Jan Hubicka <hubicka@ucw.cz>
To: "Yuan, Pengfei" <ypf@pku.edu.cn>
Cc: Jan Hubicka <hubicka@ucw.cz>,
Richard Biener <richard.guenther@gmail.com>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH, 5.x/6.x/7.x] Be more conservative in early inliner if FDO is enabled
Date: Fri, 16 Sep 2016 12:56:00 -0000 [thread overview]
Message-ID: <20160916120037.GB3781@kam.mff.cuni.cz> (raw)
In-Reply-To: <6ad18072.d732.15732c834ea.Coremail.ypf@pku.edu.cn>
> > > I also like a new param better as it avoids a new magic constant and
> > > makes playing with
> > > it easier (your patch removes the ability to do statistics like you did via the
> > > early-inlining-insns parameter by forcing it to two).
> >
> > Hmm, you are right that you do not know if this particular function will get
> > profile (forgot about that). Still, please use two params - it is more
> > consistent with what we have now and we may make it profile specific in
> > future..
> >
> > Honza
> > >
> > > Thanks,
> > > Richard.
>
> A new patch for trunk is attached.
>
> Regards,
> Yuan, Pengfei
>
>
> 2016-09-16 Yuan Pengfei <ypf@pku.edu.cn>
>
> * doc/invoke.texi (--param early-inlining-insns-feedback): New.
> * ipa-inline.c (want_early_inline_function_p): Use
> PARAM_EARLY_INLINING_INSNS_FEEDBACK when FDO is enabled.
> * params.def (PARAM_EARLY_INLINING_INSNS_FEEDBACK): Define.
> (PARAM_EARLY_INLINING_INSNS): Change help string accordingly.
OK,
thanks
Honza
next prev parent reply other threads:[~2016-09-16 12:00 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 6:41 Yuan, Pengfei
2016-09-14 10:35 ` Richard Biener
2016-09-15 3:17 ` Yuan, Pengfei
2016-09-15 8:44 ` Richard Biener
2016-09-15 10:08 ` Yuan, Pengfei
2016-09-16 5:52 ` Yuan, Pengfei
2016-09-16 8:09 ` Jan Hubicka
2016-09-16 9:01 ` Yuan, Pengfei
2016-09-16 9:21 ` Richard Biener
2016-09-16 9:37 ` Jan Hubicka
2016-09-16 12:00 ` Yuan, Pengfei
2016-09-16 12:56 ` Jan Hubicka [this message]
2016-09-20 8:53 ` Yuan, Pengfei
2016-09-20 11:44 ` Richard Biener
2016-09-20 11:58 ` Richard Biener
2016-09-20 12:09 ` Yuan, Pengfei
2016-09-20 12:19 ` Richard Biener
2016-09-20 13:10 ` Yuan, Pengfei
2016-09-21 12:44 ` Yuan, Pengfei
2016-09-26 4:03 ` Yuan, Pengfei
2016-10-10 2:23 ` PING: [PATCH] " Yuan, Pengfei
2016-10-10 9:55 ` Richard Biener
2016-10-10 10:52 ` Yuan, Pengfei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160916120037.GB3781@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=richard.guenther@gmail.com \
--cc=ypf@pku.edu.cn \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).