From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 111657 invoked by alias); 16 Sep 2016 12:00:57 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 111561 invoked by uid 89); 16 Sep 2016 12:00:50 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.0 required=5.0 tests=AWL,BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=HTo:D*edu.cn, HTo:D*cn, H*MI:sk:6ad1807, H*i:sk:6ad1807 X-HELO: nikam.ms.mff.cuni.cz Received: from nikam.ms.mff.cuni.cz (HELO nikam.ms.mff.cuni.cz) (195.113.20.16) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 16 Sep 2016 12:00:40 +0000 Received: by nikam.ms.mff.cuni.cz (Postfix, from userid 16202) id DBC5D544357; Fri, 16 Sep 2016 14:00:37 +0200 (CEST) Date: Fri, 16 Sep 2016 12:56:00 -0000 From: Jan Hubicka To: "Yuan, Pengfei" Cc: Jan Hubicka , Richard Biener , GCC Patches Subject: Re: [PATCH, 5.x/6.x/7.x] Be more conservative in early inliner if FDO is enabled Message-ID: <20160916120037.GB3781@kam.mff.cuni.cz> References: <58f49a76.4c20.15712b20e40.Coremail.ypf@pku.edu.cn> <392727ce.b9c7.1572b385ece.Coremail.ypf@pku.edu.cn> <339617a6.8f06.1573166cbaf.Coremail.ypf@pku.edu.cn> <20160916072531.GB69806@kam.mff.cuni.cz> <355e6f53.95d3.1573230b35b.Coremail.ypf@pku.edu.cn> <20160916091417.GA29974@kam.mff.cuni.cz> <6ad18072.d732.15732c834ea.Coremail.ypf@pku.edu.cn> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <6ad18072.d732.15732c834ea.Coremail.ypf@pku.edu.cn> User-Agent: Mutt/1.5.21 (2010-09-15) X-SW-Source: 2016-09/txt/msg01045.txt.bz2 > > > I also like a new param better as it avoids a new magic constant and > > > makes playing with > > > it easier (your patch removes the ability to do statistics like you did via the > > > early-inlining-insns parameter by forcing it to two). > > > > Hmm, you are right that you do not know if this particular function will get > > profile (forgot about that). Still, please use two params - it is more > > consistent with what we have now and we may make it profile specific in > > future.. > > > > Honza > > > > > > Thanks, > > > Richard. > > A new patch for trunk is attached. > > Regards, > Yuan, Pengfei > > > 2016-09-16 Yuan Pengfei > > * doc/invoke.texi (--param early-inlining-insns-feedback): New. > * ipa-inline.c (want_early_inline_function_p): Use > PARAM_EARLY_INLINING_INSNS_FEEDBACK when FDO is enabled. > * params.def (PARAM_EARLY_INLINING_INSNS_FEEDBACK): Define. > (PARAM_EARLY_INLINING_INSNS): Change help string accordingly. OK, thanks Honza