From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: libstdc++ <libstdc++@gcc.gnu.org>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756
Date: Wed, 21 Sep 2016 09:43:00 -0000 [thread overview]
Message-ID: <20160921093115.GI17376@redhat.com> (raw)
In-Reply-To: <CAFk2RUYZz9MEjFr-g7j-x-vFmysHigoUPvpsyYbwhuySwjBh8g@mail.gmail.com>
On 06/09/16 09:00 +0300, Ville Voutilainen wrote:
> PR libstdc++/77288
> * include/std/optional (__is_optional_impl, __is_optional): Remove.
> (__converts_from_optional, __assigns_from_optional): New.
> (optional(_Up&&)): Use is_same instead of __is_optional.
> (optional(const optional<_Up>&)): Constrain with
> __converts_from_optional.
> (optional(optional<_Up>&&)): Likewise.
> (operator=(_Up&&)): Use is_same instead of __is_optional, check
> is_same and is_scalar.
> (operator=(const optional<_Up>&)): Constrain with
> __converts_from_optional and __assigns_from_optional.
> (operator=(optional<_Up>&&)): Likewise.
> * testsuite/20_util/optional/77288.cc: New.
> * testsuite/20_util/optional/cons/value.cc: Adjust.
OK for trunk, thanks.
next prev parent reply other threads:[~2016-09-21 9:31 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-23 14:17 Ville Voutilainen
2016-09-06 7:05 ` Ville Voutilainen
2016-09-21 9:43 ` Jonathan Wakely [this message]
2016-09-21 19:51 ` Ville Voutilainen
2016-09-22 9:01 ` Christophe Lyon
2016-09-22 9:21 ` Ville Voutilainen
2016-09-22 9:43 ` Christophe Lyon
2016-09-22 10:03 ` Ville Voutilainen
2016-09-22 10:36 ` Jonathan Wakely
2016-09-22 11:38 ` Jonathan Wakely
2016-09-22 13:32 ` Jonathan Wakely
2016-09-22 19:10 ` Christophe Lyon
2016-09-23 10:48 ` Jonathan Wakely
2016-09-27 0:22 ` Christophe Lyon
2016-09-22 20:32 ` Christophe Lyon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160921093115.GI17376@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).