From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 44985 invoked by alias); 21 Sep 2016 09:31:19 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 44298 invoked by uid 89); 21 Sep 2016 09:31:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=_up, _Up, Hx-languages-length:827 X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 21 Sep 2016 09:31:18 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 0ECFA65747; Wed, 21 Sep 2016 09:31:17 +0000 (UTC) Received: from localhost (ovpn-116-66.ams2.redhat.com [10.36.116.66]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8L9VGKI003201; Wed, 21 Sep 2016 05:31:16 -0400 Date: Wed, 21 Sep 2016 09:43:00 -0000 From: Jonathan Wakely To: Ville Voutilainen Cc: libstdc++ , "gcc-patches@gcc.gnu.org" Subject: Re: [v3 PATCH] PR libstdc++/77288 and the newest proposed resolution for LWG 2756 Message-ID: <20160921093115.GI17376@redhat.com> References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline In-Reply-To: X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.0 (2016-08-17) X-SW-Source: 2016-09/txt/msg01394.txt.bz2 On 06/09/16 09:00 +0300, Ville Voutilainen wrote: > PR libstdc++/77288 > * include/std/optional (__is_optional_impl, __is_optional): Remove. > (__converts_from_optional, __assigns_from_optional): New. > (optional(_Up&&)): Use is_same instead of __is_optional. > (optional(const optional<_Up>&)): Constrain with > __converts_from_optional. > (optional(optional<_Up>&&)): Likewise. > (operator=(_Up&&)): Use is_same instead of __is_optional, check > is_same and is_scalar. > (operator=(const optional<_Up>&)): Constrain with > __converts_from_optional and __assigns_from_optional. > (operator=(optional<_Up>&&)): Likewise. > * testsuite/20_util/optional/77288.cc: New. > * testsuite/20_util/optional/cons/value.cc: Adjust. OK for trunk, thanks.