From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 36687 invoked by alias); 22 Sep 2016 07:46:26 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 36660 invoked by uid 89); 22 Sep 2016 07:46:25 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=Hx-languages-length:2193, hundred, eye X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 22 Sep 2016 07:46:24 +0000 Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35E2A7F7BB; Thu, 22 Sep 2016 07:46:23 +0000 (UTC) Received: from redhat.com (ovpn-204-31.brq.redhat.com [10.40.204.31]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8M7kJv0011503 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Thu, 22 Sep 2016 03:46:22 -0400 Date: Thu, 22 Sep 2016 08:35:00 -0000 From: Marek Polacek To: Jakub Jelinek Cc: Martin Sebor , Jeff Law , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Fix various minor gimple-ssa-sprintf.c issues Message-ID: <20160922074619.GS19950@redhat.com> References: <20160921150954.GC7282@tucnak.redhat.com> <7f35dddc-af39-1329-cca6-33a88955a469@gmail.com> <20160922072411.GF7282@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160922072411.GF7282@tucnak.redhat.com> User-Agent: Mutt/1.7.0 (2016-08-17) X-SW-Source: 2016-09/txt/msg01495.txt.bz2 On Thu, Sep 22, 2016 at 09:24:11AM +0200, Jakub Jelinek wrote: > On Wed, Sep 21, 2016 at 06:38:54PM -0600, Martin Sebor wrote: > > On 09/21/2016 09:09 AM, Jakub Jelinek wrote: > > >When looking at PR77676, I've noticed various small formatting etc. > > >issues, like not using is_gimple_* APIs where we have them, not using > > >gimple_call_builtin_p/gimple_call_fndecl (this one actually can show up, > > >if e.g. uses the builtin with incorrect arguments (fewer, different > > >types etc.)), one pasto, 2 spaces in comments instead of 1 in the middle > > >of sentences. And, lastly 0 < var is very unusual ordering of the > > >comparison operands, while we have a couple of such cases in the sources, > > >usually it is when using 0 < var && var <= someotherconst, while > > >var > 0 is used hundred times more often. > > > > Thanks for correcting the uses of the gimple APIs! I appreciate > > your fixing the various typos as well, but I see no value in > > changing the order of operands in inequality expressions or in > > moving code around for no apparent reason. However, I won't > > The moving of code around is in just one spot, and it has a reason - > consistency. After the move, each non-_chk builtin is followed by its _chk > counterpart, before that the order has been random. > Another possible ordering that makes sense is putting all the non-_chk > builtins first and then in the same order all their _chk counterparts. > > The reason why I wrote the patch has been that when skimming the code I've > noticed the missing is_* calls, then when looking for that issue discovered > something different etc. The var > 0 vs. 0 < var is just something that > caught my eye when looking around, I don't feel too strongly about it, it > just looked weird and unexpected. There are > 50 optimize > 0 preexisting > checks elsewhere, and even far more just optimize, but none 0 < optimize. I find those 0 < var confusing and hard to read. While I know that some people prefer 0 == var (0 is not an lvalue so it catches mistakes like var = 0 instead of var == 0), I don't see why 0 < optimized would ever be preferred. Marek