public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: vogt@linux.vnet.ibm.com,
	Rainer Orth <ro@CeBiTec.Uni-Bielefeld.DE>,
	       Mike Stump <mikestump@comcast.net>,
	gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers
Date: Fri, 23 Sep 2016 15:05:00 -0000	[thread overview]
Message-ID: <20160923144836.GQ7282@tucnak.redhat.com> (raw)
In-Reply-To: <20160923144311.GA22071@linux.vnet.ibm.com>

On Fri, Sep 23, 2016 at 03:43:11PM +0100, Dominik Vogt wrote:
> Great!
> 
> But could this patch be responsible with some dg-error related
> test errors on s390x that are present with current HEAD?  E.g.
> (Sorry for the linebreaks that vim has inserted).

Very unlikely.  Are you sure it appeared only today and not more than 2
weeks ago with
        PR middle-end/77475
        * toplev.c (process_options): Temporarily set input_location
        to UNKNOWN_LOCATION around targetm.target_option.override () call.
change (also mine)?  All such dg-error lines need to be changed to use
line number 0 (i.e. expect the errors not to be on the first line of the
source which makes no sense, but without any source location, as the errors
appear on the command line, not in any sources).

> So, the test expects an error:
> 
>   /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 1 } */ 

So it should be
   /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 0 } */
instead.

	Jakub

  reply	other threads:[~2016-09-23 14:48 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-09-22 20:10 Jakub Jelinek
2016-09-23  1:21 ` Mike Stump
2016-09-23 15:02 ` Dominik Vogt
2016-09-23 15:05   ` Jakub Jelinek [this message]
2016-09-23 15:14     ` Dominik Vogt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160923144836.GQ7282@tucnak.redhat.com \
    --to=jakub@redhat.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=mikestump@comcast.net \
    --cc=ro@CeBiTec.Uni-Bielefeld.DE \
    --cc=vogt@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).