From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 117149 invoked by alias); 23 Sep 2016 14:48:48 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 117117 invoked by uid 89); 23 Sep 2016 14:48:47 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=nm, Vogt, vogt, dominik X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 14:48:45 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8927EC05ACAD; Fri, 23 Sep 2016 14:48:44 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-43.brq.redhat.com [10.40.204.43]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u8NEmfH4030133 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 23 Sep 2016 10:48:42 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id u8NEmdcC030195; Fri, 23 Sep 2016 16:48:39 +0200 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id u8NEmae7030194; Fri, 23 Sep 2016 16:48:36 +0200 Date: Fri, 23 Sep 2016 15:05:00 -0000 From: Jakub Jelinek To: vogt@linux.vnet.ibm.com, Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers Message-ID: <20160923144836.GQ7282@tucnak.redhat.com> Reply-To: Jakub Jelinek References: <20160922200546.GH7282@tucnak.redhat.com> <20160923144311.GA22071@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923144311.GA22071@linux.vnet.ibm.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-09/txt/msg01701.txt.bz2 On Fri, Sep 23, 2016 at 03:43:11PM +0100, Dominik Vogt wrote: > Great! > > But could this patch be responsible with some dg-error related > test errors on s390x that are present with current HEAD? E.g. > (Sorry for the linebreaks that vim has inserted). Very unlikely. Are you sure it appeared only today and not more than 2 weeks ago with PR middle-end/77475 * toplev.c (process_options): Temporarily set input_location to UNKNOWN_LOCATION around targetm.target_option.override () call. change (also mine)? All such dg-error lines need to be changed to use line number 0 (i.e. expect the errors not to be on the first line of the source which makes no sense, but without any source location, as the errors appear on the command line, not in any sources). > So, the test expects an error: > > /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 1 } */ So it should be /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 0 } */ instead. Jakub