From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 37628 invoked by alias); 23 Sep 2016 15:11:11 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 37544 invoked by uid 89); 23 Sep 2016 15:11:10 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.6 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RCVD_IN_DNSWL_LOW autolearn=no version=3.3.2 spammy=Very, ciao, IBM, Great X-HELO: mx0a-001b2d01.pphosted.com Received: from mx0b-001b2d01.pphosted.com (HELO mx0a-001b2d01.pphosted.com) (148.163.158.5) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 23 Sep 2016 15:11:09 +0000 Received: from pps.filterd (m0098419.ppops.net [127.0.0.1]) by mx0b-001b2d01.pphosted.com (8.16.0.17/8.16.0.17) with SMTP id u8NF8VRi075219 for ; Fri, 23 Sep 2016 11:11:07 -0400 Received: from e06smtp13.uk.ibm.com (e06smtp13.uk.ibm.com [195.75.94.109]) by mx0b-001b2d01.pphosted.com with ESMTP id 25mqb7xbcu-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Fri, 23 Sep 2016 11:11:06 -0400 Received: from localhost by e06smtp13.uk.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Fri, 23 Sep 2016 16:11:04 +0100 Received: from d06dlp02.portsmouth.uk.ibm.com (9.149.20.14) by e06smtp13.uk.ibm.com (192.168.101.143) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; Fri, 23 Sep 2016 16:11:02 +0100 Received: from b06cxnps4075.portsmouth.uk.ibm.com (d06relay12.portsmouth.uk.ibm.com [9.149.109.197]) by d06dlp02.portsmouth.uk.ibm.com (Postfix) with ESMTP id 355A3219005E for ; Fri, 23 Sep 2016 16:10:22 +0100 (BST) Received: from d06av08.portsmouth.uk.ibm.com (d06av08.portsmouth.uk.ibm.com [9.149.37.249]) by b06cxnps4075.portsmouth.uk.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u8NFB2Qh11731374 for ; Fri, 23 Sep 2016 15:11:02 GMT Received: from d06av08.portsmouth.uk.ibm.com (localhost [127.0.0.1]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u8NFB19R005075 for ; Fri, 23 Sep 2016 09:11:02 -0600 Received: from oc5510024614.ibm.com (sig-9-145-37-109.uk.ibm.com [9.145.37.109]) by d06av08.portsmouth.uk.ibm.com (8.14.4/8.14.4/NCO v10.0 AVin) with ESMTP id u8NFB1Vg005043; Fri, 23 Sep 2016 09:11:01 -0600 Received: by oc5510024614.ibm.com (Postfix, from userid 500) id C37CDC6AB; Fri, 23 Sep 2016 17:10:59 +0200 (CEST) Date: Fri, 23 Sep 2016 15:14:00 -0000 From: Dominik Vogt To: Jakub Jelinek Cc: Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org Subject: Re: [PATCH] Extend dg-{error,warning,message,bogus} line specification to allow relative line numbers Reply-To: vogt@linux.vnet.ibm.com Mail-Followup-To: vogt@linux.vnet.ibm.com, Jakub Jelinek , Rainer Orth , Mike Stump , gcc-patches@gcc.gnu.org References: <20160922200546.GH7282@tucnak.redhat.com> <20160923144311.GA22071@linux.vnet.ibm.com> <20160923144836.GQ7282@tucnak.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20160923144836.GQ7282@tucnak.redhat.com> User-Agent: Mutt/1.5.20 (2009-12-10) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 16092315-0012-0000-0000-000004635AF7 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 16092315-0013-0000-0000-0000158F9126 Message-Id: <20160923151059.GA31482@linux.vnet.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2016-09-23_07:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1609020000 definitions=main-1609230282 X-SW-Source: 2016-09/txt/msg01704.txt.bz2 On Fri, Sep 23, 2016 at 04:48:36PM +0200, Jakub Jelinek wrote: > On Fri, Sep 23, 2016 at 03:43:11PM +0100, Dominik Vogt wrote: > > Great! > > > > But could this patch be responsible with some dg-error related > > test errors on s390x that are present with current HEAD? E.g. > > (Sorry for the linebreaks that vim has inserted). > > Very unlikely. Are you sure it appeared only today and not more than 2 > weeks ago with > PR middle-end/77475 > * toplev.c (process_options): Temporarily set input_location > to UNKNOWN_LOCATION around targetm.target_option.override () call. > change (also mine)? All such dg-error lines need to be changed to use > line number 0 (i.e. expect the errors not to be on the first line of the > source which makes no sense, but without any source location, as the errors > appear on the command line, not in any sources). Yeah, thanks a lot for pointing this out, that's the right fix. Saved me bisecting this. > > So, the test expects an error: > > > > /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 1 } */ > > So it should be > /* { dg-error "arguments to .-mhotpatch=n,m. should be non-negative integers" "" { target *-*-* } 0 } */ > instead. Ciao Dominik ^_^ ^_^ -- Dominik Vogt IBM Germany