From: Jonathan Wakely <jwakely@redhat.com>
To: "François Dumont" <frs.dumont@gmail.com>
Cc: Andreas Schwab <schwab@suse.de>,
"libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
gcc-patches <gcc-patches@gcc.gnu.org>
Subject: Re: debug container mutex association
Date: Tue, 27 Sep 2016 10:32:00 -0000 [thread overview]
Message-ID: <20160927103202.GT17376@redhat.com> (raw)
In-Reply-To: <423b791c-4924-bfeb-5b54-ce9fd452bf2c@gmail.com>
On 26/09/16 22:36 +0200, François Dumont wrote:
>Fixed with attached patch.
>
>François
>
>
>On 26/09/2016 13:56, Andreas Schwab wrote:
>>FAIL: 23_containers/list/debug/invalidation/4.cc (test for excess errors)
>>Excess errors:
>>/daten/aranym/gcc/gcc-20160926/Build/m68k-linux/libstdc++-v3/include/debug/safe_sequence.tcc:89: error: 'void __gnu_debug::_Safe_iterator_base::_M_detach_single()' is protected within this context
>>/daten/aranym/gcc/gcc-20160926/Build/m68k-linux/libstdc++-v3/include/debug/safe_sequence.tcc:112: error: 'void __gnu_debug::_Safe_iterator_base::_M_detach_single()' is protected within this context
>>
>>Andreas.
>>
>
>Index: include/debug/safe_base.h
>===================================================================
>--- include/debug/safe_base.h (revision 240509)
>+++ include/debug/safe_base.h (working copy)
>@@ -121,11 +121,11 @@
> void
> _M_detach();
>
>+ public:
> /** Likewise, but not thread-safe. */
> void
> _M_detach_single() throw ();
>
>- public:
> /** Determines if we are attached to the given sequence. */
> bool
> _M_attached_to(const _Safe_sequence_base* __seq) const
Would this be a smaller change, that doesn't make the member
accessible to all code?
--- a/libstdc++-v3/include/debug/safe_base.h
+++ b/libstdc++-v3/include/debug/safe_base.h
@@ -50,6 +50,7 @@ namespace __gnu_debug
class _Safe_iterator_base
{
friend class _Safe_sequence_base;
+ template<typename> friend class _Safe_sequence;
public:
/** The sequence this iterator references; may be NULL to indicate
next prev parent reply other threads:[~2016-09-27 10:32 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-13 20:37 François Dumont
2016-09-14 9:01 ` Jonathan Wakely
2016-09-14 20:53 ` François Dumont
2016-09-15 9:15 ` Jonathan Wakely
2016-09-19 20:19 ` François Dumont
2016-09-20 8:58 ` Jonathan Wakely
2016-09-27 15:39 ` Jonathan Wakely
2016-09-27 21:14 ` François Dumont
2016-09-20 9:20 ` Jonathan Wakely
2016-09-26 11:55 ` Jonathan Wakely
2016-09-26 12:23 ` Andreas Schwab
2016-09-26 22:09 ` François Dumont
2016-09-27 10:32 ` Jonathan Wakely [this message]
2016-09-28 19:35 ` François Dumont
2016-09-28 19:47 ` Jonathan Wakely
2017-12-29 16:10 ` Andreas Schwab
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160927103202.GT17376@redhat.com \
--to=jwakely@redhat.com \
--cc=frs.dumont@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=schwab@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).