From: Alan Modra <amodra@gmail.com>
To: Joseph Myers <joseph@codesourcery.com>
Cc: gcc-patches@gcc.gnu.org, Segher Boessenkool <segher@kernel.crashing.org>
Subject: Re: [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP
Date: Wed, 28 Sep 2016 04:38:00 -0000 [thread overview]
Message-ID: <20160928020040.GH3336@bubble.grove.modra.org> (raw)
In-Reply-To: <alpine.DEB.2.20.1609280118170.17432@digraph.polyomino.org.uk>
On Wed, Sep 28, 2016 at 01:20:22AM +0000, Joseph Myers wrote:
> On Wed, 28 Sep 2016, Alan Modra wrote:
>
> > I've also added a new option, default on, that disables output of
> > .gnu_attribute tags. That's needed because this patch alone
> > introduces libstdc++ testsuite regressions, fixed by the next patch.
>
> This option is missing documentation in invoke.texi.
Oops, I'll add that.
> > +mgnu-attr
> > +Target Report Var(rs6000_gnu_attr) Init(-1) Save
> > +Emit .gnu_attribute tags.
>
> Why Init(-1)? That's normally for cases where there is code that checks
> if it's still -1 (i.e. no option passed explicitly) and does something
> different in that case, but I don't see any such code in this patch.
Yes, it can be Init(1). I copied from other options in sysv4.opt.
Incidentally, in playing with #pragma GCC target "-mno-gnu-attr" I
find that it affects all functions in a file, rather than just
functions defined later in the file. I'll look into that too.
--
Alan Modra
Australia Development Lab, IBM
next prev parent reply other threads:[~2016-09-28 2:00 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-28 1:20 Alan Modra
2016-09-28 1:26 ` [PATCH 2/2] Disable .gnu_attribute tags in compatibility-ldbl.o Alan Modra
2016-09-28 2:49 ` Joseph Myers
2016-09-28 4:41 ` Alan Modra
2016-09-28 17:34 ` Joseph Myers
2016-09-28 9:04 ` Segher Boessenkool
2016-09-28 2:00 ` [PATCH 1/2][RS6000] .gnu.attribute Tag_GNU_Power_ABI_FP Joseph Myers
2016-09-28 4:38 ` Alan Modra [this message]
2016-09-28 8:48 ` Segher Boessenkool
2016-09-29 0:57 ` Alan Modra
2016-09-29 15:14 David Edelsohn
2016-09-29 22:05 ` Alan Modra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160928020040.GH3336@bubble.grove.modra.org \
--to=amodra@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=segher@kernel.crashing.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).