From: Markus Trippelsdorf <markus@trippelsdorf.de>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: PATCH to fix bogus -Wimplicit-fallthrough warning (PR c++/77803)
Date: Sat, 01 Oct 2016 05:18:00 -0000 [thread overview]
Message-ID: <20161001051750.GA308@x4> (raw)
In-Reply-To: <20160930213150.GH3223@redhat.com>
On 2016.09.30 at 23:31 +0200, Marek Polacek wrote:
> This PR reports a bogus -Wimplicit-fallthrough warning on the attached test.
> The problem is that last_stmt_in_scope should for GIMPLE_TRY, if the last
> statement of the eval part can't fallthrough, return this statement and don't
> warn. And the same should be true for FALLTHROUGH (). This patch fixes it.
>
> Bootstrapped/regtested on x86_64-linux, ok for trunk?
Try to compile the testcase without the fallthrough attribute...
> diff --git gcc/testsuite/g++.dg/warn/Wimplicit-fallthrough-1.C gcc/testsuite/g++.dg/warn/Wimplicit-fallthrough-1.C
> index e69de29..8f80b01 100644
> --- gcc/testsuite/g++.dg/warn/Wimplicit-fallthrough-1.C
> +++ gcc/testsuite/g++.dg/warn/Wimplicit-fallthrough-1.C
> @@ -0,0 +1,16 @@
> +// PR c++/77803
> +// { dg-do compile { target c++11 } }
> +// { dg-options "-Wimplicit-fallthrough" }
> +
> +struct A {};
> +int a;
> +void fn1() {
> + switch (0) {
> + case 0: {
> + A b;
> + [[fallthrough]];
> + }
> + default:
> + a = 0;
> + }
> +}
>
> Marek
>
--
Markus
next prev parent reply other threads:[~2016-10-01 5:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-30 21:39 Marek Polacek
2016-10-01 5:18 ` Markus Trippelsdorf [this message]
2016-10-01 14:42 ` Marek Polacek
2016-10-02 18:42 ` Jason Merrill
2016-10-02 21:57 ` Jakub Jelinek
2016-10-07 8:45 ` Marek Polacek
2016-10-07 9:39 ` Jakub Jelinek
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161001051750.GA308@x4 \
--to=markus@trippelsdorf.de \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).