From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 82793 invoked by alias); 5 Oct 2016 12:40:31 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 67083 invoked by uid 89); 5 Oct 2016 12:40:19 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-3.5 required=5.0 tests=BAYES_00,KAM_LAZY_DOMAIN_SECURITY,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 05 Oct 2016 12:40:09 +0000 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 29AAA8E249; Wed, 5 Oct 2016 12:40:08 +0000 (UTC) Received: from localhost (ovpn-116-122.ams2.redhat.com [10.36.116.122]) by int-mx11.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u95Ce7lI027810; Wed, 5 Oct 2016 08:40:07 -0400 Date: Wed, 05 Oct 2016 12:40:00 -0000 From: Jonathan Wakely To: libstdc++@gcc.gnu.org, gcc-patches@gcc.gnu.org Subject: Re: [PATCH] PR 70564 disambiguate constructors for not_fn call wrapper Message-ID: <20161005124007.GN29482@redhat.com> References: <20161005113116.GA31323@redhat.com> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="Cp3Cp8fzgozWLBWL" Content-Disposition: inline In-Reply-To: <20161005113116.GA31323@redhat.com> X-Clacks-Overhead: GNU Terry Pratchett User-Agent: Mutt/1.7.0 (2016-08-17) X-SW-Source: 2016-10/txt/msg00231.txt.bz2 --Cp3Cp8fzgozWLBWL Content-Type: text/plain; charset=us-ascii; format=flowed Content-Disposition: inline Content-length: 1010 On 05/10/16 12:31 +0100, Jonathan Wakely wrote: >diff --git a/libstdc++-v3/testsuite/20_util/not_fn/1.cc b/libstdc++-v3/testsuite/20_util/not_fn/1.cc >index 375c7cc..8d6e9ec 100644 >--- a/libstdc++-v3/testsuite/20_util/not_fn/1.cc >+++ b/libstdc++-v3/testsuite/20_util/not_fn/1.cc >@@ -84,6 +84,12 @@ test04() > VERIFY( not_fn(f)(d) ); > } > >+void >+test05() >+{ >+ auto nf{ std::not_fn([] { return false; }) }; >+} >+ > int > main() > { >diff --git a/libstdc++-v3/testsuite/experimental/functional/not_fn.cc b/libstdc++-v3/testsuite/experimental/functional/not_fn.cc >index d508028..59d7621 100644 >--- a/libstdc++-v3/testsuite/experimental/functional/not_fn.cc >+++ b/libstdc++-v3/testsuite/experimental/functional/not_fn.cc >@@ -84,6 +84,12 @@ test04() > VERIFY( not_fn(f)(d) ); > } > >+void >+test05() >+{ >+ auto nf{ not_fn([] { return false; }) }; >+} >+ > int > main() > { Gah, this aren't the tests I meant to commit. Fixed on trunk like so, with tests that actually failed before the fix. --Cp3Cp8fzgozWLBWL Content-Type: text/x-patch; charset=us-ascii Content-Disposition: attachment; filename="patch.txt" Content-length: 1224 commit 998cf48ef12d44d215acb70f80600e46648da94f Author: Jonathan Wakely Date: Wed Oct 5 13:19:38 2016 +0100 70564 fix newly-added tests for not_fn PR libstdc++/70564 * testsuite/20_util/not_fn/1.cc: Fix test. * testsuite/experimental/functional/not_fn.cc: Likewise. diff --git a/libstdc++-v3/testsuite/20_util/not_fn/1.cc b/libstdc++-v3/testsuite/20_util/not_fn/1.cc index 8d6e9ec..233a6d3 100644 --- a/libstdc++-v3/testsuite/20_util/not_fn/1.cc +++ b/libstdc++-v3/testsuite/20_util/not_fn/1.cc @@ -87,7 +87,8 @@ test04() void test05() { - auto nf{ std::not_fn([] { return false; }) }; + auto nf = std::not_fn([] { return false; }); + auto copy(nf); // PR libstdc++/70564 } int diff --git a/libstdc++-v3/testsuite/experimental/functional/not_fn.cc b/libstdc++-v3/testsuite/experimental/functional/not_fn.cc index 59d7621..525f59c 100644 --- a/libstdc++-v3/testsuite/experimental/functional/not_fn.cc +++ b/libstdc++-v3/testsuite/experimental/functional/not_fn.cc @@ -87,7 +87,8 @@ test04() void test05() { - auto nf{ not_fn([] { return false; }) }; + auto nf = std::experimental::not_fn([] { return false; }); + auto copy(nf); // PR libstdc++/70564 } int --Cp3Cp8fzgozWLBWL--