From: Jakub Jelinek <jakub@redhat.com>
To: Marek Polacek <polacek@redhat.com>
Cc: GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: Fix missing -Wimplicit-fallthrough warning
Date: Fri, 07 Oct 2016 12:30:00 -0000 [thread overview]
Message-ID: <20161007123018.GH7282@tucnak.redhat.com> (raw)
In-Reply-To: <20161005165254.GV3223@redhat.com>
On Wed, Oct 05, 2016 at 06:52:55PM +0200, Marek Polacek wrote:
> Ping.
>
> On Thu, Sep 29, 2016 at 06:10:27PM +0200, Marek Polacek wrote:
> > Here, a missing -Wimplicit-fallthrough warning was caused by a misplaced
> > FALLTHROUGH_LABEL_P check. As it is now, for FALLTHROUGH_LABEL_P we'd
> > never gotten around to
> > 1933 /* So that next warn_implicit_fallthrough_r will start looking for
> > 1934 a new sequence starting with this label. */
> > 1935 gsi_prev (gsi_p);
> >
> > The fix is to move the check to should_warn_for_implicit_fallthrough.
> >
> > Bootstrapped/regtested on x86_64-linux and ppc64-linux, ok for trunk?
> >
> > 2016-09-29 Marek Polacek <polacek@redhat.com>
> >
> > * gimplify.c (should_warn_for_implicit_fallthrough): Check for
> > FALLTHROUGH_LABEL_P here...
> > (warn_implicit_fallthrough_r): ...not here.
> >
> > * c-c++-common/Wimplicit-fallthrough-22.c: New test.
Ok, thanks.
Jakub
prev parent reply other threads:[~2016-10-07 12:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-29 16:26 Marek Polacek
2016-10-05 16:53 ` Marek Polacek
2016-10-07 12:30 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161007123018.GH7282@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).