From: Jakub Jelinek <jakub@redhat.com>
To: John David Anglin <dave.anglin@bell.net>
Cc: Jason Merrill <jason@redhat.com>, DJ Delorie <dj@redhat.com>,
Bernd Edlinger <bernd.edlinger@hotmail.de>,
gcc-patches List <gcc-patches@gcc.gnu.org>,
Jeff Law <law@redhat.com>
Subject: Re: [PATCH] Implement new hook for max_align_t_align
Date: Tue, 11 Oct 2016 20:57:00 -0000 [thread overview]
Message-ID: <20161011205725.GE7282@tucnak.redhat.com> (raw)
In-Reply-To: <d2368fcb-45e6-3e94-0244-6b69eef97f38@bell.net>
On Tue, Oct 11, 2016 at 04:54:56PM -0400, John David Anglin wrote:
> But the check isn't directly about malloc. It's between the alignment for
> max_align_t
> and the alignment that the type wants. Joseph indicated that max_align_t
> should have an
> alignment as large as the POSIX types (e.g., pthread_mutex_t). So, I think
> setting it to 16
> when pthread_mutex_t wants an alignment of 16 is correct.
But precondition of bumping max_align_t to 16 is IMHO that malloc actually
provides that alignment. If that is not the case, then I think you should
just drop the alignment attribute from pthread_mutex_t etc. and deal with
the ABI change.
Jakub
next prev parent reply other threads:[~2016-10-11 20:57 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-08 17:01 Bernd Edlinger
2016-10-08 17:36 ` John David Anglin
2016-10-09 8:35 ` Bernd Edlinger
2016-10-09 17:52 ` John David Anglin
2016-10-10 18:21 ` John David Anglin
2016-10-11 18:51 ` Jason Merrill
2016-10-11 18:59 ` DJ Delorie
2016-10-11 20:12 ` Jason Merrill
2016-10-11 20:55 ` John David Anglin
2016-10-11 20:57 ` Jakub Jelinek [this message]
2016-10-11 21:27 ` Jason Merrill
2016-10-11 20:04 ` John David Anglin
2016-10-12 7:02 ` Carlos O'Donell
2016-10-12 7:25 ` Jakub Jelinek
2016-10-12 7:52 ` Florian Weimer
2016-10-12 8:02 ` Jakub Jelinek
2016-10-12 12:13 ` John David Anglin
2016-10-12 12:33 ` Bernd Schmidt
2016-10-12 12:43 ` Richard Biener
2016-10-12 12:46 ` Bernd Schmidt
2016-10-12 15:51 ` Joseph Myers
2016-10-12 13:48 ` Jason Merrill
2016-10-12 14:17 ` John David Anglin
2016-10-12 19:59 ` Carlos O'Donell
2016-10-12 16:14 ` Jeff Law
2016-10-12 17:24 ` John David Anglin
2017-02-25 17:46 ` Gerald Pfeifer
2017-02-25 22:13 ` John David Anglin
2017-02-25 22:46 ` Gerald Pfeifer
2017-02-25 23:46 ` John David Anglin
2016-10-12 18:01 ` Florian Weimer
2016-10-12 18:13 ` John David Anglin
-- strict thread matches above, loose matches on Subject: below --
2016-10-08 16:43 Bernd Edlinger
2016-10-08 15:45 John David Anglin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161011205725.GE7282@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bernd.edlinger@hotmail.de \
--cc=dave.anglin@bell.net \
--cc=dj@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=jason@redhat.com \
--cc=law@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).