From: Jan Hubicka <hubicka@ucw.cz>
To: kugan <kugan.vivekanandarajah@linaro.org>
Cc: Richard Biener <rguenther@suse.de>, Jan Hubicka <hubicka@ucw.cz>,
"gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [RFC][IPA-VRP] ADDR_EXPR and nonnull
Date: Thu, 20 Oct 2016 12:15:00 -0000 [thread overview]
Message-ID: <20161020121524.GC19926@kam.mff.cuni.cz> (raw)
In-Reply-To: <76ab5854-4c4e-ae4a-8d33-e2b1bdd02522@linaro.org>
> Hi Richard,
>
>
> On 20/10/16 18:41, Richard Biener wrote:
> >On Thu, 20 Oct 2016, kugan wrote:
> >
> >>
> >>
> >>On 20/10/16 01:26, Jan Hubicka wrote:
> >>>>>Would excluding weak symbols (I believe I can check DECL_WEAK for this)
> >>>>>good
> >>>>>enough. Or looking for acceptable subset would work?
> >>>>
> >>>>I think we should add a symtab helper to tell if address_nonzero_p (if
> >>>>that doesn't aleady exist).
> >>>
> >>>We have node->nonzero_address()
> >>
> >>Thanks for the pointer. Here is an attempt. Does this look OK?
> >>
> >>+ if (TREE_CODE (arg) == ADDR_EXPR)
> >>+ {
> >>+ /* See if the AADR_EXPR is nonnull. */
> >>+ varpool_node *node = NULL;
> >>+ tree base = TREE_OPERAND (arg, 0);
> >>+ base = get_base_address (base);
> >>+
> >>+ if (decl_address_ip_invariant_p (base)
> >>+ || !is_global_var (base))
> >>+ {
> >>+ /* If the symbol address is local or
> >>+ constant. */
> >
> >"constant" doesn't matter. You want
> >
> > if (TREE_CODE (base) == CONST_DECL
> >|| TREE_CODE (base) == PARM_DECL
> >|| TREE_CODE (base) == RESULT_DECL)
> > addr_nonzero = true;
> > else if (VAR_P (base))
Better to check decl_in_symtab_p (decl)
> > addr_nonzero = ! is_global_var (base) || (varpool_node::get
> >(base)->nonzero_address ());
and symtab_node::get.
I wonder if we can't unify the logic with tree_expr_nonzero_warnv_p
and corresponding vrp code?
Otherwise the patch looks fine to me.
Honza
next prev parent reply other threads:[~2016-10-20 12:15 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-19 2:12 kugan
2016-10-19 8:24 ` Richard Biener
2016-10-19 8:48 ` kugan
2016-10-19 9:26 ` Richard Biener
2016-10-19 14:26 ` Jan Hubicka
2016-10-20 3:13 ` kugan
2016-10-20 7:42 ` Richard Biener
2016-10-20 11:56 ` kugan
2016-10-20 12:09 ` Richard Biener
2016-10-20 12:15 ` Jan Hubicka [this message]
2016-10-21 3:39 ` kugan
2016-10-21 7:16 ` Richard Biener
2016-10-21 7:38 ` kugan
2016-10-21 8:08 ` Richard Biener
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161020121524.GC19926@kam.mff.cuni.cz \
--to=hubicka@ucw.cz \
--cc=gcc-patches@gcc.gnu.org \
--cc=kugan.vivekanandarajah@linaro.org \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).