From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 72201 invoked by alias); 1 Nov 2016 16:05:33 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 72143 invoked by uid 89); 1 Nov 2016 16:05:32 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.4 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=istarget, UD:target-supports.exp, 8110,7, libfunc X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 01 Nov 2016 16:05:31 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 35A9B8124D; Tue, 1 Nov 2016 16:05:30 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-204-19.brq.redhat.com [10.40.204.19]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uA1G5SLq012993 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Tue, 1 Nov 2016 12:05:29 -0400 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id uA1G5QZ1007086; Tue, 1 Nov 2016 17:05:27 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id uA1G5Ptb007085; Tue, 1 Nov 2016 17:05:25 +0100 Date: Tue, 01 Nov 2016 16:05:00 -0000 From: Jakub Jelinek To: Uros Bizjak , Prathamesh Kulkarni Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH, testsuite]: Cleanup lib/target-supports.exp, ... Message-ID: <20161101160525.GV3541@tucnak.redhat.com> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.24 (2015-08-30) X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg00053.txt.bz2 On Tue, Nov 01, 2016 at 10:05:22AM +0100, Uros Bizjak wrote: > ... simplify some conditions and add i?86-*-* target where missing. > > 2016-11-01 Uros Bizjak > > * lib/target-supports.exp: Normalize order of i?86 and x86_64 targets. > Whitespace fixes. ... > (check_effective_target_divmod): Add i?86-*-* target. This part likely broke +FAIL: gcc.dg/divmod-1.c scan-tree-dump-times widening_mul "DIVMOD" 7 +FAIL: gcc.dg/divmod-2.c scan-tree-dump-times widening_mul "DIVMOD" 7 +FAIL: gcc.dg/divmod-3.c scan-tree-dump-times widening_mul "DIVMOD" 7 +FAIL: gcc.dg/divmod-4.c scan-tree-dump-times widening_mul "DIVMOD" 7 +FAIL: gcc.dg/divmod-6.c scan-tree-dump-times widening_mul "DIVMOD" 7 on i686-linux (i.e. 32-bit). Dunno what exactly the tests are meant to test, most likely they just need extra guards or something. Can be reproduced even on x86_64-linux with make check-gcc RUNTESTFLAGS='--target_board=unix\{-m32,-m64\} dg.exp=divmod*' > @@ -8110,7 +8090,7 @@ > #TODO: Add checks for all targets that have either hardware divmod insn > # or define libfunc for divmod. > if { [istarget arm*-*-*] > - || [istarget x86_64-*-*] } { > + || [istarget i?86-*-*] || [istarget x86_64-*-*] } { > return 1 > } > return 0 Jakub