From: Jonathan Wakely <jwakely@redhat.com>
To: Ville Voutilainen <ville.voutilainen@gmail.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
libstdc++ <libstdc++@gcc.gnu.org>
Subject: Re: [v3 PATCH] Implement P0504R0 (Revisiting in-place tag types for any/optional/variant).
Date: Sun, 13 Nov 2016 21:03:00 -0000 [thread overview]
Message-ID: <20161113210252.GH21992@redhat.com> (raw)
In-Reply-To: <CAFk2RUYehjAUhYye_aEM1YFcfzmw+p-2Z=3ZYBaPiPBffNwCaQ@mail.gmail.com>
On 12/11/16 21:24 +0200, Ville Voutilainen wrote:
>+ inline in_place_t in_place{};
>+
>+ template<typename _Tp> struct in_place_type_t
>+ {
>+ explicit in_place_type_t() = default;
>+ };
>+
>+ template<typename _Tp>
>+ in_place_type_t<_Tp> in_place_type{};
>+
>+ template<size_t _Idx> struct in_place_index_t
>+ {
>+ explicit in_place_index_t() = default;
>+ };
>+
>+ template<size_t _Idx>
>+ in_place_index_t<_Idx> in_place_index{};
I was told there's a Core issue that says these are not actually
inline variables unless they say "inline". Not sure which issue that
is, but G++ does the right thing and makes them globally unique,
rather than having internal linkage.
(At LWG's request P0504R0 marked them inline just to be safe.)
OK for trunk, thanks.
next prev parent reply other threads:[~2016-11-13 21:03 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-12 19:24 Ville Voutilainen
2016-11-13 21:03 ` Jonathan Wakely [this message]
2016-11-13 21:10 ` Jonathan Wakely
2016-11-13 22:44 ` Jonathan Wakely
2016-11-14 20:49 ` Ville Voutilainen
2016-11-14 20:51 ` Ville Voutilainen
2016-11-15 9:12 ` Ville Voutilainen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161113210252.GH21992@redhat.com \
--to=jwakely@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
--cc=ville.voutilainen@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).