From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 69808 invoked by alias); 15 Nov 2016 17:01:42 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 69712 invoked by uid 89); 15 Nov 2016 17:01:41 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-0.1 required=5.0 tests=AWL,BAYES_40,RCVD_IN_DNSWL_NONE,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=HAuthentication-Results:gcc.gnu.org, HReceived-SPF:SPF, Undocumented, Bootstrapped X-HELO: EUR02-VE1-obe.outbound.protection.outlook.com Received: from mail-eopbgr20064.outbound.protection.outlook.com (HELO EUR02-VE1-obe.outbound.protection.outlook.com) (40.107.2.64) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 15 Nov 2016 17:01:30 +0000 Received: from VI1PR0801CA0022.eurprd08.prod.outlook.com (10.167.193.160) by DB6PR0801MB1782.eurprd08.prod.outlook.com (10.169.227.17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.734.8; Tue, 15 Nov 2016 17:01:26 +0000 Received: from DB3FFO11FD022.protection.gbl (2a01:111:f400:7e04::172) by VI1PR0801CA0022.outlook.office365.com (2603:10a6:800:32::32) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P384) id 15.1.721.10 via Frontend Transport; Tue, 15 Nov 2016 17:01:26 +0000 Authentication-Results: spf=permerror (sender IP is 217.140.96.140) smtp.mailfrom=arm.com; gcc.gnu.org; dkim=none (message not signed) header.d=none;gcc.gnu.org; dmarc=none action=none header.from=arm.com; Received-SPF: PermError (protection.outlook.com: domain of arm.com used an invalid SPF mechanism) Received: from nebula.arm.com (217.140.96.140) by DB3FFO11FD022.mail.protection.outlook.com (10.47.217.53) with Microsoft SMTP Server (version=TLS1_0, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA_P384) id 15.1.721.5 via Frontend Transport; Tue, 15 Nov 2016 17:01:25 +0000 X-IncomingTopHeaderMarker: OriginalChecksum:;UpperCasedChecksum:;SizeAsReceived:1047;Count:14 Received: from arm.com (10.1.2.79) by mail.arm.com (10.1.106.66) with Microsoft SMTP Server id 14.3.294.0; Tue, 15 Nov 2016 17:01:14 +0000 Date: Tue, 15 Nov 2016 17:01:00 -0000 From: James Greenhalgh To: Andrew Pinski CC: Kyrill Tkachov , GCC Patches , Marcus Shawcroft , Richard Earnshaw , Subject: Re: [PATCH/AARCH64] Have the verbose cost model output output be controllable Message-ID: <20161115170113.GA38182@arm.com> References: <57F75656.2000407@foss.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-IncomingHeaderCount: 14 X-EOPAttributedMessage: 0 X-MS-Office365-Filtering-HT: Tenant X-Forefront-Antispam-Report: CIP:217.140.96.140;IPV:CAL;SCL:-1;CTRY:GB;EFV:NLI;SFV:NSPM;SFS:(10009020)(6009001)(7916002)(2980300002)(448002)(377454003)(24454002)(199003)(189002)(54534003)(54356999)(8676002)(50986999)(76176999)(626004)(8936002)(104016004)(246002)(106466001)(26826002)(7696004)(5660300001)(110136003)(2950100002)(6916009)(356003)(305945005)(7846002)(23726003)(1076002)(1411001)(2906002)(4326007)(92566002)(189998001)(50466002)(46406003)(36756003)(229853002)(4001350100001)(47776003)(77096005)(85326001)(97756001)(83506001)(33656002)(86362001)(87936001)(18370500001);DIR:OUT;SFP:1101;SCL:1;SRVR:DB6PR0801MB1782;H:nebula.arm.com;FPR:;SPF:PermError;PTR:fw-tnat.cambridge.arm.com;A:1;MX:1;LANG:en; X-Microsoft-Exchange-Diagnostics: 1;DB3FFO11FD022;1:ymVD4fL6dpD2xIlugxR9efg+GkYhmkP8eqfvb04uXMjHzdaLQpdZo7s6tVILjI56zJC31C04Jd3uGQhPPsNCWKK+A1mW52JVvBFMgN99cVy/M2H6C0rQzLUZOxOimEjo4uRbqdv3VA8d+PMt8M7RN/V8MXTprubqB8GLDO4i4Eee/RqYuxeVtXxbJaS/UVRk4TdKuMZg50I8KNGestMcN2H1aupEbV2bmRonReVakwuTYwjmqpQXiBjl3cnioPuWRG0WAnRfZWORzwKB65wol3Aj7cKwaqihoP8PCTSGrkzPgphMGb5rfNWoz8zRbjsFha+gYRLDr8OgEQliZ8kmXvn1wYG7NiPbdovRV7uT+RW4zYeyfsTGjVSyUPYMJSyRaiuuDqqd1Tj9kVI73Mz6qC1YJzQB9VdgonBk2mUECdxYE0p/R01P+i13XODlMI/Y6pHjJWwtYdDljdj2qUqDstfzCccrWbhM55zFEqyzEbjBLRXELLW3s87Jy3FeTSWQlsSfElXLu9l1nde3xt+NSH1Rs3uMpmk+6utrALrSK0gmVKDy5yd1jNcd0eNSVftBzxIm9UVCS4ut9LU4F9nolghc3TnyKYI0oRQ/GRQAoRs= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;2:xWr3f2drzkPJWxDcaijsQN7rUx88Y8tYsAy2pkBJWhKKcPWiqrMQ22ufYMCAcjvsHPHMfLCsmi1GYqx+3zFohUsjfepCOl0nB/TDRgJVNIvUgLaEfBXLdch/Y8ovz8vQHDk9SCY/8gO+rPyhgBVS5N6nGgFiPwMhg2VNAtHOmwA=;3:13FeDUwrfU7G+BOu5ZGl9IaQ3zuiL85jzO4joGjavIAdZizhTACRvI3aoNtJh00jmONLB/YwoYdmjWK1WZL760OY4/8WL1ByM4QqPIap1eQykG78f3E4SflASZJC0JTFIHR43YLM0OFAh66kFmgnFmwHJrCruGppm3Ao6a5r4/CI+rJaZkJN0gjtvQJJTH/L5ELxVmHpCdJbDEy9Z95tUTMkd4XZ4ZFcuUKkw/A41v8B//2Z9MskThTEqEZ3CNhKsZnaTaD9EFF+LlrfyeIl0Q== X-MS-Office365-Filtering-Correlation-Id: 8d74584e-c3fe-4d98-2111-08d40d7908d3 X-Microsoft-Antispam: UriScan:;BCL:0;PCL:0;RULEID:(22001);SRVR:DB6PR0801MB1782; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;25:tWxfmB8Y/gLpuFwbc/18USXEJ41RSfRNuHZjO4Jz83Kge5jUNt1DOKMHyC3qWWYiRl6tkFavetG8IzaD9qxVC8ivOfSDoKOG5BblKa/rUkqFRIE7g8EKBOUPOjYy5p+YIFjlMDOVR/Cst4fC+e8xzPPsCPhoYbjefAkuXusttytlakjWfZ3XZEcXjDnWcBoHpTJKJqcQh9/86y6EpbuckGd1VPpX5Mq0dZtzJmAiLYv/+/ujUPhVSDkUt7elum5qefKAHJOwDzxvcTsHuK1aw2V6vq/NbKLubfiAysjfVX7xxGRPoHaIGJDAFNciJmE/OFDuv9/Ulh0GMlPL8KAOuicMVOxyUrXN1iH4Fn5Zg6plzBWZ+4NfIy+TC+tlMMzuB7R7yRJznpedXkoQbF1ryLS/ZUYhL/DECK+s3NIDqcNumKfEw97rKCZabeu23qxqUoA+Txod6RiGkZ/Oyos+KjZGqC86cPjHBbnr72HybnGs4i8d5rTa0RDyaS4ieTbsaBR5HNE1URnN6NpEfxysAIRy+ccGtT7h6UFK5sEUBSXmhDufFjJ1h2WWWE7QTN4asguCv3cLGzLihLSEbb4IJCEOjynoP+XzU8y5loaZZB2goHLcmqPPj4PI59WkP/HsIS1L2zboATZc6+rqrZoyFhhYOy6T4ojlkqfbcBcjdP6yCFtU//7hw5QYAE1rRY/uxvS/M+CvnJ+QuCXBl0tHWdznwGcXZUF0ZTSJ3j1MAxCE7M69xAmkEquxQv7zgQaH7TNj36Z9JU62N8Zp5qACB4rmIzWxOlVQgHjBAQBu3952Prqb4nR+vUrIJfdLm323yeYZL9tJWQ7HMXb+H0zDo8jGu5xaXWcSicAUkTY4SvE= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;31:Nhs+QVH4KirFRtdY1+xxX0ellS1ZmKvm6UX4ok4lEK39u/gDRtnf+wK+jkw73AL6C56Z6chPHXy2GJSdFehSLrtL5bMcuLLvCKJp+4cowUdwgeV03cd/eFXM/EzVnyKQG0O4j+DSGrWNvs4fjJRFi7wqs/bAp3tDXMThjHEX+hXZ6EMDYPT5gE57wkRLoZfIBbY+kGhFE6R/4ILnNymjCpzGs8N0sCk3sGf3VV24AlwkxpS6zXiUyZYVfZZQ7CqAUwENilabKyC6yp0H1IV1qQ==;20:zgcpgvY0g+906HqneFRIjlIqb/ODuZBJ55kF0TdFbRLuk8wjxZNkhlgIcQNWc9LZlfbPXVtajxM9ovEdZGEM4qSQjxioXNs5UDnETuZIRRfmED/pp496yiFlu0L2z24r/7s9uFCqWNHgLY0MXr7FJD63w+P0kEtXn5nIHlwdbJXfppXvUME2othAj2wrvDdn0sFl1lbzHwTOflSHJB3kiRi8OhECEzSQiCJ/I6nYtIftlceucrq2NkaWVEBuZqK7 NoDisclaimer: True X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:(180628864354917); X-Exchange-Antispam-Report-CFA-Test: BCL:0;PCL:0;RULEID:(6060326)(601004)(2401047)(13023025)(13020025)(13013025)(13024025)(8121501046)(5005006)(10201501046)(3002001)(6055026)(6061324);SRVR:DB6PR0801MB1782;BCL:0;PCL:0;RULEID:;SRVR:DB6PR0801MB1782; X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;4:syPwiJ9iXUUkBS9il9PnUDOF0t215l8NoUTi2o2wHhCZYyXPFFJhkxa5zhnoVQrGWUXC0Wjpl4McK43o6ZkTrAP8jrMmK8fR/m5eQi7IfNC81D3UFTmEfSn/uQw9OM1ttvTPGUSF9oR403YE63K9h4NDHP4ZjYtUvlkQJVPrOtimHDxb7++/apdmuO0ZBf7AOlCrCt4F3W/Ix+asioSWHyQy33b1YRDaqMoRHbIo0+TZ8iXGM5JjEfrTh4JXB4rStnnbJ2xFW+/rfHSXOvlvN0mC893/xpp+rFCtK0+SoLIa1wzSl6DBVnYOGZmvvDoVTD05KGI7WNVfD1hxN2WMHrZAvjIqVH0zaPMAR129snBxg/q1WbwPCAuS26wMe+f+uSJZXuPSKp2F3rgX7G6cjYB2mxtSjdbOYrpldjcGHjbowusL/zehj1/g8o8lHJ8HdkJMORyl/vqRxfl9tO6SoRussNyDDHojANAgHB4Y1PhR85j3E+xuLxywoQeINY0dhHsmGkMv2L5KlsJef6nk1/MErTJc6cIz/CHQwnd9or+R5jBswi2nFye8lNb5E77R X-Forefront-PRVS: 012792EC17 X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1;DB6PR0801MB1782;23:Meo30v6LuNzY6fPOd0/v8g48+olmnD9OElImWp0?= =?us-ascii?Q?8km3VHdiVumQsdLfg3yIRqnPTL4U6qEaZa9mNBJ7QAnRsGoAL9owIzWQlNC3?= =?us-ascii?Q?0rPHDNej/JHCeM5M3avgNbiCDNRZbV0UTPmsvSC5cTzB0whW+f+NuiiyH+ti?= =?us-ascii?Q?jpsQhJeyeEZnVtRk1kPPUbAmjIDeEUt7HT+1NIVc6vPXoQgoaJpwiBmAFIuH?= =?us-ascii?Q?XKneKZ29KH+/eJNY76Ca1LESrmil9cbFfsrgXmTCUdqpto+F5gHZdzTY1S1f?= =?us-ascii?Q?6iVCzMDPo7rdTr6xMz7/fGf2IpsFhPG75PpPymvolY/I6S2BEn4B9BmkFw93?= =?us-ascii?Q?O0LkJIYrvhzsSeH6MK1mYMzSFYG5GA2n9PffH4yH429lVxBnRBqdtbuWCvqx?= =?us-ascii?Q?6TOpp+Qjt9kwEUAhbjBbfdgCIKmbH2Xvn3Rxxm+JhnANiifZ6wJpG4JFB06j?= =?us-ascii?Q?AkFANXyO1Nj/DpUA7A4aTgddRtmDclkfncKKrKFuHrmiOvxcir52qzd5N0Sv?= =?us-ascii?Q?KGOIH/1khBmRvSENYy/Y5h+wVXjrKK+oMFrGaN3fPlskxwXWnsaGKhfoc078?= =?us-ascii?Q?FIsYXvws34grHk6Mwd8jlrMrEKx0DUBG4DCoxchHkyxKpDJRhpIz3eWbTYnk?= =?us-ascii?Q?tXa9yDiPZy1Lr3prbOzm3hWhsgNfHYf0GHudFWVKWsPPCiYsby0pzbGJ5+/q?= =?us-ascii?Q?gjvuQNW8D7OtPeylLptqrjg6XG6kDJpe11tnWhGJsKvBvJwA+sgBIDT4OgZi?= =?us-ascii?Q?PEc/bLiEpnqWR90TBY4hyQiN5mIQT5SPKDspjCeomBgEudYGkmcvkIbIeUrZ?= =?us-ascii?Q?buP3CHKE+IBGYnAZtADi3tLU5xICikQx1ersM4VEt+58zyPlRQXtUgcPgWK8?= =?us-ascii?Q?8OXGwQ22qm3oXIKXLViDg973EcHHGfwVRIOqCKrH/4S7Fe5k5OXh0NUOLco1?= =?us-ascii?Q?1xc1k0wmQB37vktFJQDeJXsx3eTCWNWD7ICvWVAdFuw/dh3fAkC0y/Ivs1Uy?= =?us-ascii?Q?YhbjNR5vSKKhYKiHMLNao4sl0o2NedDSOAQQTMA9gynTZq0FWoR919T9GjfZ?= =?us-ascii?Q?/HPri6FvLlBWFifWqZIKg0R6dyDDyneGrjnWySZKxAEZVyPM45m6Ll2kWPrs?= =?us-ascii?Q?C+jKFgLmsXQ+8Lc0WJa7NRC7Td1xmaofhUgO06xI+6gMylPqGBfYDHZXZKD3?= =?us-ascii?Q?d5IbFwyH2ZV7cUUs=3D?= X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;6:DSfwqAqlZR8ylfg4MhfYqZcaaFmX6rUBmQ7sXyOKHs5U0D291sJCE8bxva/cWHAYZMhQHba81nAbUqJytjTk7LsIawAQyCtCpzzC831EnWH/BmaAOQlHPXVL8Bfqc/1RogLMd4RphSZd4/xkaf2UqZwPRsFcZ7UUt2wSNYrC/SnWlzi8nbp9kD6Wv0w9ouVhx6oSJtV1G7cvhpnpkQbZHJQslJTP6j7M6kEhlRAnc8d6YUFLvXoBUIV2mvsVduJ4csNCRTlksgNxGXZoDaGs3SoWRjnjZ2ofqJuNAK4PGfHCs2NJmW5euw1tEqFdwR84vjfBjp3SEkRgErrOcexs7dm4sXpFOStGTfxarWMuu64Y5hoZvgNbWTp1M32dW+GS;5:zjhRckVza4rV5zJ4cUcKl58dzOVxlBz9QMhwHA4ega9uQZ7EIEgdGkAyB7PXdks9ggrRV9UlxChg8n3oEIxY1RWM5VF/QSQIyc3XjvCtg693a13PU2MYxkFeKGIr5UCOR62n2jd1HrBHQf2qYYxEEQ==;24:R1IeEgE6LWnlFuJny+pfrieMwQ6Q0+4jl3kyhErqfui7f1SI4O1TfGixhQ9qL1sUdRsZg1eURorTBiv6HVTgy9X9LXlEMb3+mFQbCTReXUA= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1;DB6PR0801MB1782;7:7ZPKbFtrEJB+v1PsNG4o+aln26+XM1Ztw9QILihXH3ePDTeJy5JU4cZFiroRL1fEkOJaK80lVRvCe5fx7+MPvafiw3D8uxw0wo9gKZWp/9zjDZ7XBPUVU/F05BO2HUF7xEpyFGNEKYyuENAekH95n0UD31rSjFO+OUVjlDaxRhkIS8+5YvxP6QvoCTX/hIoQdLS1llqEeLpDkd8ixLWkyrJHf4YU3c7EiY/p7AHs6/nLI1IKXalKnYuk27LzL6uvUuuZWqCNoebeOS/7EhzUsv53+BSoACOiw/g2VfzY1QUssYCVSTDbCmgu63cEWffMvpSRvH/Wqr5PLjE2tWQ9AhKhoZffyPduP1S5NV+T6T0= X-OriginatorOrg: arm.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 15 Nov 2016 17:01:25.3844 (UTC) X-MS-Exchange-CrossTenant-Id: f34e5979-57d9-4aaa-ad4d-b122a662184d X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=f34e5979-57d9-4aaa-ad4d-b122a662184d;Ip=[217.140.96.140];Helo=[nebula.arm.com] X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: DB6PR0801MB1782 X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01505.txt.bz2 On Tue, Nov 15, 2016 at 08:48:04AM -0800, Andrew Pinski wrote: > On Fri, Oct 7, 2016 at 1:01 AM, Kyrill Tkachov > wrote: > > Hi Andrew, > > > > > > On 24/09/16 06:46, Andrew Pinski wrote: > >> > >> Hi, > >> As reported in PR 61367, the aarch64 back-end is too verbose when it > >> is dealing with the cost model. I tend to agree, no other back-end is > >> this verbose. So I decided to add an option to enable this verbose > >> output if requested. > >> > >> I did NOT document it in invoke.texi because I don't feel like this is > >> an option which an user should use. But I can add it if requested. > >> > >> OK? Bootstrapped and tested on aarch64-linux-gnu with no regressions. > >> > >> Thanks, > >> Andrew Pinski > >> > >> ChangeLog: > >> * config/aarch64/aarch64.opt (mverbose-cost-dump): New option. > >> * config/aarch64/aarch64.c (aarch64_rtx_costs): Use > >> flag_aarch64_verbose_cost instead of checking for details dump. > >> (aarch64_rtx_costs_wrapper): Likewise. > > > > > > I'm okay with the idea, but I can't approve (cc'ing people who can). > > Ping? I think after having AArch64 back-end developers frustrated by the mountains of dump output for two years it is a good time to relent... This is OK with Kyrill's change applied. Thanks, James > > > > One nit: > > > > +mverbose-cost-dump > > +Common Var(flag_aarch64_verbose_cost) > > +Enables verbose cost model dummping in the debug dump files. > > > > You should add "Undocumented" to that. > > I don't think the option is major enough to warrant an entry in invoke.texi. > > It's only for aarch64 backend developers who know exactly what they're > > looking for. > > > > Cheers, > > Kyrill > > > >