From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 99786 invoked by alias); 18 Nov 2016 11:12:15 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 99773 invoked by uid 89); 18 Nov 2016 11:12:14 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-4.6 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:8.13.8 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Nov 2016 11:12:13 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id uAIBC8iP021263; Fri, 18 Nov 2016 05:12:09 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id uAIBC85x021262; Fri, 18 Nov 2016 05:12:08 -0600 Date: Fri, 18 Nov 2016 11:12:00 -0000 From: Segher Boessenkool To: Richard Biener Cc: gcc-patches@gcc.gnu.org, stevenb.gcc@gmail.com, law@redhat.com Subject: Re: [PATCH v3] bb-reorder: Improve compgotos pass (PR71785) Message-ID: <20161118111206.GI3732@gate.crashing.org> References: <3df81960ce19c2de4869049ea1b5f07a8261cf71.1479414653.git.segher@kernel.crashing.org> <20161118090726.GG3732@gate.crashing.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20161118090726.GG3732@gate.crashing.org> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2016-11/txt/msg01907.txt.bz2 On Fri, Nov 18, 2016 at 03:07:27AM -0600, Segher Boessenkool wrote: > rtl_merge_blocks does not check rtl_can_merge_blocks_p (and you get a > quite spectacular ICE when you get it wrong: everything between the two > blocks is deleted :-) ). I'll make a separate patch that checks it > (layout mode already does). This fails in cfgcleanup.c (in merge_blocks_move_successor_nojumps), on the "a->next_bb == b" test. Oh well. Segher