From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <gcc-patches-return-441923-listarch-gcc-patches=gcc.gnu.org@gcc.gnu.org>
Received: (qmail 104645 invoked by alias); 18 Nov 2016 11:15:43 -0000
Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm
Precedence: bulk
List-Id: <gcc-patches.gcc.gnu.org>
List-Archive: <http://gcc.gnu.org/ml/gcc-patches/>
List-Post: <mailto:gcc-patches@gcc.gnu.org>
List-Help: <mailto:gcc-patches-help@gcc.gnu.org>
Sender: gcc-patches-owner@gcc.gnu.org
Received: (qmail 104619 invoked by uid 89); 18 Nov 2016 11:15:42 -0000
Authentication-Results: sourceware.org; auth=none
X-Virus-Found: No
X-Spam-SWARE-Status: No, score=-4.8 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=trend
X-HELO: mx1.redhat.com
Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 18 Nov 2016 11:15:41 +0000
Received: from int-mx10.intmail.prod.int.phx2.redhat.com (int-mx10.intmail.prod.int.phx2.redhat.com [10.5.11.23])	(using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))	(No client certificate requested)	by mx1.redhat.com (Postfix) with ESMTPS id B7A168124A;	Fri, 18 Nov 2016 11:15:40 +0000 (UTC)
Received: from tucnak.zalov.cz (ovpn-204-19.brq.redhat.com [10.40.204.19])	by int-mx10.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id uAIBFdM8019206	(version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO);	Fri, 18 Nov 2016 06:15:40 -0500
Received: from tucnak.zalov.cz (localhost [127.0.0.1])	by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id uAIBFb7e010858;	Fri, 18 Nov 2016 12:15:37 +0100
Received: (from jakub@localhost)	by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id uAIBFaqp010857;	Fri, 18 Nov 2016 12:15:36 +0100
Date: Fri, 18 Nov 2016 11:15:00 -0000
From: Jakub Jelinek <jakub@redhat.com>
To: Chung-Lin Tang <chunglin_tang@mentor.com>
Cc: gcc-patches <gcc-patches@gcc.gnu.org>, Nathan Sidwell <nathan@acm.org>,        Cesar Philippidis <cesar@codesourcery.com>
Subject: Re: [Patch 2/5] OpenACC tile clause support, omp-low parts
Message-ID: <20161118111536.GU3541@tucnak.redhat.com>
Reply-To: Jakub Jelinek <jakub@redhat.com>
References: <c5f37d54-c921-50c0-6b42-b4b6fa5813b0@mentor.com> <20161111100030.GV3541@tucnak.redhat.com> <b5b14823-7ff8-8cb3-9faa-3782b7ab6af1@mentor.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <b5b14823-7ff8-8cb3-9faa-3782b7ab6af1@mentor.com>
User-Agent: Mutt/1.5.24 (2015-08-30)
X-IsSubscribed: yes
X-SW-Source: 2016-11/txt/msg01909.txt.bz2

Hi!

On Thu, Nov 17, 2016 at 05:31:40PM +0800, Chung-Lin Tang wrote:
> +#ifndef ACCEL_COMPILER
> +  span = integer_one_node;
> +#else
> +  if (!e_mask)
> +    /* Not paritioning.  */
> +    span = integer_one_node;
...
This goes against the recent trend of avoiding #if/#ifdef guarded blocks
of code as much as possible, the ACCEL_COMPILER only hunk is significant
and will usually not be enabled, so people will not notice breakages in it
until building an accel compiler.
What about
#ifndef ACCEL_COMPILER
  if (true)
    span = integer_one_node;
  else
#endif
  if (!e_mask)
    /* Not paritioning.  */
    span_integer_one_node;
  else if
...
or what I've proposed earlier:
#ifndef ACCEL_COMPILER                                                                                                                             
  e_mask = 0;                                                                                                                                      
#endif                                                                                                                                             
  if (!e_mask)                                                                                                                                     
...

Ok with that fixed.

	Jakub