From: Jakub Jelinek <jakub@redhat.com>
To: GCC Patches <gcc-patches@gcc.gnu.org>, Martin Liska <mliska@suse.cz>
Subject: Re: [PATCH 1/4] Remove build dependence on HSA run-time
Date: Tue, 22 Nov 2016 14:13:00 -0000 [thread overview]
Message-ID: <20161122141325.GT3541@tucnak.redhat.com> (raw)
In-Reply-To: <20161122132744.lrxg63wvfa3qfvhf@virgil.suse.cz>
On Tue, Nov 22, 2016 at 02:27:44PM +0100, Martin Jambor wrote:
> I have basically copied what libgfortran did, with additional checking
> for HAVE_UNISTD_H when attempting to implement secure_getenv in its
> absence (which is maybe unnecessary but should not do any harm) and I
> also needed to add -D_GNU_SOURCE to plugin compilation flags.
> Finally, I have changed all getenv users in the plugin to use
> secure_getenv.
I'm not sure about the all getenv users to secure_getenv, for the
specification of the library to dlopen it is essential, for the rest it
is debatable; but it is your choice.
> +hsa_status_t hsa_executable_validate(hsa_executable_t executable,
> + uint32_t *result);
> +uint64_t hsa_queue_add_write_index_acq_rel(const hsa_queue_t *queue,
> + uint64_t value);
...
> +hsa_status_t hsa_executable_readonly_variable_define(
> + hsa_executable_t executable, hsa_agent_t agent, const char *variable_name,
> + void *address);
If hsa.h is our header rather than one imported from somewhere else,
can you tweak the formatting (space before (, in the last above case
wrap after type to allow more arguments on a line?
If it is just imported from somewhere else, please disregard.
Otherwise LGTM.
Jakub
next prev parent reply other threads:[~2016-11-22 14:13 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-13 23:20 [PATCH 0/4] Merge from HSA branch to trunk Martin Jambor
2016-11-13 23:20 ` [PATCH 3/4] OpenMP lowering changes from the hsa branch Martin Jambor
2016-11-18 10:39 ` Jakub Jelinek
2016-03-16 14:13 ` [omp] Create openmp -fopt-info optimization group Martin Jambor
2017-02-21 8:09 ` [gomp4] add -finform-parallelism Cesar Philippidis
2017-02-22 8:28 ` Thomas Schwinge
2017-02-23 15:06 ` Cesar Philippidis
2016-11-22 13:43 ` [PATCH 3/4] OpenMP lowering changes from the hsa branch Martin Jambor
2017-02-22 7:58 ` Rename the "openmp" group of optimizations to "omp" (was: [PATCH 3/4] OpenMP lowering changes from the hsa branch) Thomas Schwinge
2017-02-22 8:17 ` Miscellaneous optimization group fixes (was: Rename the "openmp" group of optimizations to "omp") Thomas Schwinge
2017-02-22 9:53 ` Martin Jambor
2017-02-28 8:52 ` Rename the "openmp" group of optimizations to "omp" (was: Miscellaneous optimization group fixes) Thomas Schwinge
2017-02-28 9:04 ` Miscellaneous optimization group fixes Thomas Schwinge
2016-11-13 23:20 ` [PATCH 2/4] HSA specific built-ins Martin Jambor
2016-11-18 10:27 ` Jakub Jelinek
2016-11-22 13:30 ` Martin Jambor
2016-11-13 23:20 ` [PATCH 1/4] Remove build dependence on HSA run-time Martin Jambor
2016-11-18 10:23 ` Jakub Jelinek
2016-11-22 13:27 ` Martin Jambor
2016-11-22 14:13 ` Jakub Jelinek [this message]
2021-01-14 14:50 ` Thomas Schwinge
2021-01-19 11:37 ` Martin Jambor
2021-01-19 12:49 ` Martin Liška
2021-03-25 13:40 ` Thomas Schwinge
2022-04-06 9:20 ` libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time) Thomas Schwinge
2022-04-06 9:24 ` Jakub Jelinek
2022-04-06 9:54 ` libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library Thomas Schwinge
2022-04-28 13:48 ` [PING] libgomp testsuite: Don't amend 'LD_LIBRARY_PATH' for system-provided HSA Runtime library (was: [PATCH 1/4] Remove build dependence on HSA run-time) Thomas Schwinge
2022-05-05 19:20 ` [PING^2] " Thomas Schwinge
2022-04-06 10:02 ` libgomp GCN plugin: Clean up unused references to " Thomas Schwinge
2022-04-28 13:50 ` [PING] " Thomas Schwinge
2022-04-28 14:18 ` Andrew Stubbs
2022-05-11 12:38 ` libgomp GCN plugin: Clean up always-empty 'PLUGIN_GCN_CPPFLAGS', 'PLUGIN_GCN_LDFLAGS' (was: libgomp GCN plugin: Clean up unused references to system-provided HSA Runtime library) Thomas Schwinge
2022-05-11 12:40 ` libgomp: Remove unused '--with-hsa-runtime', '--with-hsa-runtime-include', '--with-hsa-runtime-lib' " Thomas Schwinge
2016-11-13 23:20 ` [PATCH 4/4] Back-end and IPA bits of hsa branch merge Martin Jambor
[not found] ` <yxfpftb48jra.fsf@hertz.schwinge.homeip.net>
2020-06-17 21:57 ` [HSA] Avoid ICE when "HSA does not implement indirect calls" (was: [PATCH 4/4] Back-end and IPA bits of hsa branch merge) Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161122141325.GT3541@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=mliska@suse.cz \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).