From: Segher Boessenkool <segher@kernel.crashing.org>
To: Michael Matz <matz@suse.de>
Cc: Jakub Jelinek <jakub@redhat.com>, gcc-patches@gcc.gnu.org
Subject: Re: Fix pr78390: bootstrap on ia64 and s390x (with zEC12)
Date: Wed, 23 Nov 2016 14:28:00 -0000 [thread overview]
Message-ID: <20161123142819.GA6099@gate.crashing.org> (raw)
In-Reply-To: <alpine.LSU.2.20.1611231437140.31313@wotan.suse.de>
On Wed, Nov 23, 2016 at 02:45:23PM +0100, Michael Matz wrote:
> > Shouldn't new_rtx be set to NULL_RTX if that condition is false? Otherwise
> > it will be whatever make_compound_operation returned. What about the break?
> > Shouldn't that be done only if the condition is true too?
>
> Hmm? The conditionial statement only guards the adjustment of len if that
> happens to be too large to be completely contained inside new_rtx.
new_rtx shouldn't be set at all here for non-constant shifts, because
those have the same problem as this new conditional tries to solve.
I'm committing a similar patch, see other thread.
Segher
prev parent reply other threads:[~2016-11-23 14:28 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-23 13:27 Michael Matz
2016-11-23 13:35 ` Jakub Jelinek
2016-11-23 13:45 ` Michael Matz
2016-11-23 14:28 ` Segher Boessenkool [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161123142819.GA6099@gate.crashing.org \
--to=segher@kernel.crashing.org \
--cc=gcc-patches@gcc.gnu.org \
--cc=jakub@redhat.com \
--cc=matz@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).