From: Jakub Jelinek <jakub@redhat.com>
To: Bernd Schmidt <bschmidt@redhat.com>
Cc: Richard Biener <rguenther@suse.de>, Jeff Law <law@redhat.com>,
Eric Botcazou <ebotcazou@adacore.com>,
gcc-patches@gcc.gnu.org
Subject: Re: [PATCH] Unset used bit in simplify_replace_* on newly copied rtxs (PR target/78614)
Date: Fri, 02 Dec 2016 16:05:00 -0000 [thread overview]
Message-ID: <20161202160511.GZ3541@tucnak.redhat.com> (raw)
In-Reply-To: <01ce97c6-b60e-7930-b5cd-0f82eaebdf98@redhat.com>
On Fri, Dec 02, 2016 at 03:51:52PM +0100, Bernd Schmidt wrote:
> I like this a lot better. Of course now that it's spelled out it seems like
> several of these (PC, CC0, RETURN, maybe SCRATCH) should never be passed to
> shallow_copy_rtx and maybe a checking_assert to that effect might be in
> order. This part is OK.
Ok, I've committed the parts except simplify-rtx.c.
> After looking at it more, I feel that here as well it seems strange for
> simplify_replace_fn_rtx to have knowledge about these issues. Doesn't this
> belong in shallow_copy_rtx as well?
Started working on that, but it seems e.g. copy_insn_1 doesn't want this
behavior, it has a complex system of sharing some of the subvectors
of ASM_OPERANDS.
Jakub
prev parent reply other threads:[~2016-12-02 16:05 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-11-30 22:11 Jakub Jelinek
2016-12-01 12:19 ` Bernd Schmidt
2016-12-01 22:43 ` Jakub Jelinek
2016-12-01 22:48 ` Bernd Schmidt
2016-12-01 23:34 ` Jakub Jelinek
2016-12-02 14:13 ` Jakub Jelinek
2016-12-02 14:51 ` Bernd Schmidt
2016-12-02 16:05 ` Jakub Jelinek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161202160511.GZ3541@tucnak.redhat.com \
--to=jakub@redhat.com \
--cc=bschmidt@redhat.com \
--cc=ebotcazou@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=law@redhat.com \
--cc=rguenther@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).