From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 74664 invoked by alias); 7 Dec 2016 16:25:50 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 74646 invoked by uid 89); 7 Dec 2016 16:25:49 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.0 required=5.0 tests=AWL,BAYES_00,SPF_NEUTRAL autolearn=no version=3.3.2 spammy=Hx-languages-length:751, H*f:sk:1481121, H*MI:sk:1481121, H*i:sk:1481121 X-HELO: mail2-relais-roc.national.inria.fr Received: from mail2-relais-roc.national.inria.fr (HELO mail2-relais-roc.national.inria.fr) (192.134.164.83) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 07 Dec 2016 16:25:47 +0000 Received: from nat-inria-bordeaux-52-gw-01-bso.bordeaux.inria.fr (HELO var.youpi.perso.aquilenet.fr) ([194.199.1.52]) by mail2-relais-roc.national.inria.fr with ESMTP/TLS/AES256-GCM-SHA384; 07 Dec 2016 17:25:30 +0100 Received: from samy by var.youpi.perso.aquilenet.fr with local (Exim 4.88) (envelope-from ) id 1cEf29-0001Fw-U3; Wed, 07 Dec 2016 17:25:29 +0100 Date: Wed, 07 Dec 2016 16:25:00 -0000 From: Samuel Thibault To: Svante Signell Cc: bug-hurd , Debian GCC Maintainers , gcc-patches Subject: Re: Hurd port for gcc go PATCH 1-4(23) Message-ID: <20161207162529.GH7661@var.bordeaux.inria.fr> Mail-Followup-To: Svante Signell , bug-hurd , Debian GCC Maintainers , gcc-patches References: <20161126231752.GH2658@var.home> <1480264432.24382.154.camel@gmail.com> <20161127170215.GC8854@var.home> <1481118755.9077.9.camel@gmail.com> <20161207140813.GF7661@var.bordeaux.inria.fr> <1481121151.9077.27.camel@gmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1481121151.9077.27.camel@gmail.com> User-Agent: Mutt/1.5.21+34 (58baf7c9f32f) (2010-12-30) X-SW-Source: 2016-12/txt/msg00570.txt.bz2 Svante Signell, on Wed 07 Dec 2016 15:32:31 +0100, wrote: > On Wed, 2016-12-07 at 15:08 +0100, Samuel Thibault wrote: > > Ok, but then I'd say move the function which change to a separate file, > > so that the other functions are kept shared. > > Otherwise it'll be tedious to maintain. > > One problem is the file go/syscall/libcall_posix-1.go, derived > from go/syscall/libcall_posix.go but _removing_ four function definitions: > mount, madvise, mlockall and munlockall. That's not a problem: move them out to another file, and include that file in the non-gnu case, but do not include that file in the gnu case. Actually it's even odd to see mount among them, it's not a standard posix interface. Samuel