From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 92431 invoked by alias); 15 Dec 2016 22:10:34 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 92420 invoked by uid 89); 15 Dec 2016 22:10:34 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.0 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,SPF_PASS autolearn=ham version=3.3.2 spammy=games, Hx-languages-length:718, cuts X-HELO: paperclip.tbsaunde.org Received: from tbsaunde.org (HELO paperclip.tbsaunde.org) (66.228.47.254) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Thu, 15 Dec 2016 22:10:33 +0000 Received: from ball (unknown [IPv6:2607:f0c8:8000:80e0:56ee:75ff:fe52:afb9]) by paperclip.tbsaunde.org (Postfix) with ESMTPSA id 99EE1C06B; Thu, 15 Dec 2016 22:10:30 +0000 (UTC) Date: Thu, 15 Dec 2016 22:34:00 -0000 From: Trevor Saunders To: gcc-patches@gcc.gnu.org, richard.sandiford@arm.com Subject: Re: [2/67] Make machine_mode a class Message-ID: <20161215222116.qutavhj3ltfl6etz@ball> References: <87h96dp8u6.fsf@e105548-lin.cambridge.arm.com> <878trpp8ng.fsf@e105548-lin.cambridge.arm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <878trpp8ng.fsf@e105548-lin.cambridge.arm.com> User-Agent: NeoMutt/20161126 (1.7.1) X-SW-Source: 2016-12/txt/msg01425.txt.bz2 On Fri, Dec 09, 2016 at 12:52:03PM +0000, Richard Sandiford wrote: > This patch renames enum machine_mode to enum machine_mode_enum > and adds a machine_mode wrapper class. > > The previous patch mechanically replaced mode names in case > statements; this one updates other places that should continue > to use the enum directly. > > The patch continues to use enums for static variables. This isn't > necessary, but it cuts down on the amount of load-time initialisation > and shouldn't have any downsides. We should probably add a GCC_CONSTEXPR macro so we can get that advantage without having to play games like this, but this case doesn't seem like too big of a deal. Trev