From: Arnaud Charlet <charlet@adacore.com>
To: Simon Wright <simon@pushface.org>
Cc: gcc-patches@gcc.gnu.org, Ed Schonberg <schonberg@adacore.com>
Subject: Re: [Ada] Fix PR ada/78845
Date: Wed, 21 Dec 2016 15:03:00 -0000 [thread overview]
Message-ID: <20161221145227.GA809@adacore.com> (raw)
In-Reply-To: <4D07E255-BDCD-47AC-A546-926E024E2425@pushface.org>
> > Yes, please resend an updated patch.
>
> The function Ada.Numerics.Generic_Real_Arrays.Inverse is required
> (ARM G.3.1(72)) to
> return a matrix with the bounds of the dimension indices swapped, i.e.
> result'Range(1) ==
> input'Range(2) and vice versa. The present code gets result'Range(1)
> correct, but
> result'Range(2) always starts at 1.
>
> Of course, many users would always use ranges starting at 1 and wouldn't see a
> problem.
>
> The same applies to Ada.Numerics.Complex_Real_Arrays.Inverse (ARM
> G.3.2(140)).
Updated patch OK as well.
> 2016-12-21 Simon Wright <simon@pushface.org
> <mailto:simon@pushface.org>>
>
> PR ada/78845
> * a-ngcoar.adb (Inverse): call Unit_Matrix with First_1 set to
> A'First(2)
> and vice versa.
> * a-ngrear.adb (Inverse): likewise.
next prev parent reply other threads:[~2016-12-21 14:52 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 11:10 Simon Wright
2016-12-20 12:14 ` Arnaud Charlet
[not found] ` <B2185111-5A47-432A-B562-A65199236B25@pushface.org>
2016-12-21 8:52 ` Arnaud Charlet
[not found] ` <4D07E255-BDCD-47AC-A546-926E024E2425@pushface.org>
2016-12-21 15:03 ` Arnaud Charlet [this message]
2017-01-10 11:18 ` Simon Wright
2017-01-10 12:02 ` Arnaud Charlet
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20161221145227.GA809@adacore.com \
--to=charlet@adacore.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=schonberg@adacore.com \
--cc=simon@pushface.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).