* [PATCh] Avoid in gcc.target/powerpc/ -m32 or -m64 in dg-options (PR target/77416)
@ 2017-01-11 19:41 Jakub Jelinek
2017-01-18 12:56 ` Ping Re: [PATCH] " Jakub Jelinek
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2017-01-11 19:41 UTC (permalink / raw)
To: Segher Boessenkool, David Edelsohn; +Cc: gcc-patches
Hi!
The pr77416.c test fails in some configurations, where the -m32 option
is not supported. The following patch fixes that by guarding the test
with ilp32 effective target and removing the -m32 and adjusts a couple of
tests that already have ilp32 or lp64 guard, but have useless -m32 or -m64
in dg-options in addition to that.
Bootstrapped/regtested on powerpc64le-linux, ok for trunk?
2017-01-11 Jakub Jelinek <jakub@redhat.com>
PR target/77416
* gcc.target/powerpc/pr77416.c Guard the test only for ilp32 effective
target. Use powerpc* instead of powerpc64* in targets. Remove -m32
from dg-options.
* gcc.target/powerpc/pr64205.c: Remove -m32 from dg-options of ilp32
guarded test.
* gcc.target/powerpc/fusion4.c: Likewise.
* gcc.target/powerpc/pr63491.c: Remove -m64 from dg-options of lp64
guarded test.
* gcc.target/powerpc/pr58673-1.c: Likewise.
* gcc.target/powerpc/pr58673-2.c: Likewise.
* gcc.target/powerpc/pr59054.c: Likewise.
--- gcc/testsuite/gcc.target/powerpc/pr77416.c.jj 2016-09-20 10:25:59.000000000 +0200
+++ gcc/testsuite/gcc.target/powerpc/pr77416.c 2017-01-11 14:18:32.565621295 +0100
@@ -1,7 +1,7 @@
-/* { dg-do compile { target { powerpc64*-*-*} } } */
-/* { dg-skip-if "" { powerpc64-*-aix* } { "*" } { "" } } */
-/* { dg-skip-if "do not override -mcpu" { powerpc64*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */
-/* { dg-options "-mcpu=power7 -O2 -m32" } */
+/* { dg-do compile { target { { powerpc*-*-* } && ilp32 } } } */
+/* { dg-skip-if "" { powerpc*-*-aix* } { "*" } { "" } } */
+/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */
+/* { dg-options "-mcpu=power7 -O2" } */
/* { dg-final { scan-assembler-times "addze" 1 } } */
extern int fn2 ();
--- gcc/testsuite/gcc.target/powerpc/pr64205.c.jj 2015-02-16 11:19:03.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/pr64205.c 2017-01-11 14:20:22.696200110 +0100
@@ -1,7 +1,7 @@
/* { dg-do compile { target { powerpc*-*-* && ilp32 } } } */
/* { dg-skip-if "" { powerpc*-*-aix* } { "*" } { "" } } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=G5" } } */
-/* { dg-options "-O2 -mcpu=G5 -maltivec -m32" } */
+/* { dg-options "-O2 -mcpu=G5 -maltivec" } */
union ieee754r_Decimal32
{
--- gcc/testsuite/gcc.target/powerpc/fusion4.c.jj 2016-11-18 20:04:20.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/fusion4.c 2017-01-11 14:19:59.929493904 +0100
@@ -2,7 +2,7 @@
/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
/* { dg-require-effective-target powerpc_p9vector_ok } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */
-/* { dg-options "-mcpu=power7 -mtune=power9 -O3 -msoft-float -m32" } */
+/* { dg-options "-mcpu=power7 -mtune=power9 -O3 -msoft-float" } */
#define LARGE 0x12345
--- gcc/testsuite/gcc.target/powerpc/pr63491.c.jj 2015-03-20 12:34:48.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/pr63491.c 2017-01-11 14:21:59.880953359 +0100
@@ -1,5 +1,5 @@
/* { dg-do compile { target { powerpc*-*-* && lp64 } } } */
-/* { dg-options "-O1 -m64 -mcpu=power8 -mlra" } */
+/* { dg-options "-O1 -mcpu=power8 -mlra" } */
typedef __int128_t __attribute__((__vector_size__(16))) vector_128_t;
typedef unsigned long long scalar_64_t;
--- gcc/testsuite/gcc.target/powerpc/pr58673-1.c.jj 2014-11-11 00:05:43.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/pr58673-1.c 2017-01-11 14:21:07.224627429 +0100
@@ -2,7 +2,7 @@
/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
-/* { dg-options "-mcpu=power8 -m64 -O1" } */
+/* { dg-options "-mcpu=power8 -O1" } */
enum typecode
{
--- gcc/testsuite/gcc.target/powerpc/pr58673-2.c.jj 2014-11-11 00:05:43.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/pr58673-2.c 2017-01-11 14:21:22.336433978 +0100
@@ -2,7 +2,7 @@
/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
/* { dg-require-effective-target powerpc_p8vector_ok } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power8" } } */
-/* { dg-options "-mcpu=power8 -O3 -m64 -funroll-loops" } */
+/* { dg-options "-mcpu=power8 -O3 -funroll-loops" } */
#include <stddef.h>
#include <stdlib.h>
--- gcc/testsuite/gcc.target/powerpc/pr59054.c.jj 2014-11-11 00:05:43.000000000 +0100
+++ gcc/testsuite/gcc.target/powerpc/pr59054.c 2017-01-11 14:21:39.076219687 +0100
@@ -2,6 +2,6 @@
/* { dg-skip-if "" { powerpc*-*-darwin* } { "*" } { "" } } */
/* { dg-require-effective-target powerpc_vsx_ok } */
/* { dg-skip-if "do not override -mcpu" { powerpc*-*-* } { "-mcpu=*" } { "-mcpu=power7" } } */
-/* { dg-options "-mcpu=power7 -O0 -m64" } */
+/* { dg-options "-mcpu=power7 -O0" } */
long foo (void) { return 0; }
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
* Ping Re: [PATCH] Avoid in gcc.target/powerpc/ -m32 or -m64 in dg-options (PR target/77416)
2017-01-11 19:41 [PATCh] Avoid in gcc.target/powerpc/ -m32 or -m64 in dg-options (PR target/77416) Jakub Jelinek
@ 2017-01-18 12:56 ` Jakub Jelinek
2017-01-18 15:33 ` Segher Boessenkool
0 siblings, 1 reply; 3+ messages in thread
From: Jakub Jelinek @ 2017-01-18 12:56 UTC (permalink / raw)
To: Segher Boessenkool, David Edelsohn; +Cc: gcc-patches
Hi!
On Wed, Jan 11, 2017 at 08:41:02PM +0100, Jakub Jelinek wrote:
> The pr77416.c test fails in some configurations, where the -m32 option
> is not supported. The following patch fixes that by guarding the test
> with ilp32 effective target and removing the -m32 and adjusts a couple of
> tests that already have ilp32 or lp64 guard, but have useless -m32 or -m64
> in dg-options in addition to that.
>
> Bootstrapped/regtested on powerpc64le-linux, ok for trunk?
>
> 2017-01-11 Jakub Jelinek <jakub@redhat.com>
>
> PR target/77416
> * gcc.target/powerpc/pr77416.c Guard the test only for ilp32 effective
> target. Use powerpc* instead of powerpc64* in targets. Remove -m32
> from dg-options.
> * gcc.target/powerpc/pr64205.c: Remove -m32 from dg-options of ilp32
> guarded test.
> * gcc.target/powerpc/fusion4.c: Likewise.
> * gcc.target/powerpc/pr63491.c: Remove -m64 from dg-options of lp64
> guarded test.
> * gcc.target/powerpc/pr58673-1.c: Likewise.
> * gcc.target/powerpc/pr58673-2.c: Likewise.
> * gcc.target/powerpc/pr59054.c: Likewise.
I'd like to ping this patch, ok for trunk?
Jakub
^ permalink raw reply [flat|nested] 3+ messages in thread
* Re: Ping Re: [PATCH] Avoid in gcc.target/powerpc/ -m32 or -m64 in dg-options (PR target/77416)
2017-01-18 12:56 ` Ping Re: [PATCH] " Jakub Jelinek
@ 2017-01-18 15:33 ` Segher Boessenkool
0 siblings, 0 replies; 3+ messages in thread
From: Segher Boessenkool @ 2017-01-18 15:33 UTC (permalink / raw)
To: Jakub Jelinek; +Cc: David Edelsohn, gcc-patches
On Wed, Jan 18, 2017 at 01:51:12PM +0100, Jakub Jelinek wrote:
> > The pr77416.c test fails in some configurations, where the -m32 option
> > is not supported. The following patch fixes that by guarding the test
> > with ilp32 effective target and removing the -m32 and adjusts a couple of
> > tests that already have ilp32 or lp64 guard, but have useless -m32 or -m64
> > in dg-options in addition to that.
> >
> > Bootstrapped/regtested on powerpc64le-linux, ok for trunk?
> >
> > 2017-01-11 Jakub Jelinek <jakub@redhat.com>
> >
> > PR target/77416
> > * gcc.target/powerpc/pr77416.c Guard the test only for ilp32 effective
> > target. Use powerpc* instead of powerpc64* in targets. Remove -m32
> > from dg-options.
> > * gcc.target/powerpc/pr64205.c: Remove -m32 from dg-options of ilp32
> > guarded test.
> > * gcc.target/powerpc/fusion4.c: Likewise.
> > * gcc.target/powerpc/pr63491.c: Remove -m64 from dg-options of lp64
> > guarded test.
> > * gcc.target/powerpc/pr58673-1.c: Likewise.
> > * gcc.target/powerpc/pr58673-2.c: Likewise.
> > * gcc.target/powerpc/pr59054.c: Likewise.
>
> I'd like to ping this patch, ok for trunk?
Yes, thank you! Sorry for failing to reply before.
Segher
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2017-01-18 15:31 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-11 19:41 [PATCh] Avoid in gcc.target/powerpc/ -m32 or -m64 in dg-options (PR target/77416) Jakub Jelinek
2017-01-18 12:56 ` Ping Re: [PATCH] " Jakub Jelinek
2017-01-18 15:33 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).