* [PATCH, rs6000] Fix for test_ne_int() built-in test case.
@ 2017-01-13 22:58 Carl E. Love
2017-01-14 10:41 ` Segher Boessenkool
0 siblings, 1 reply; 2+ messages in thread
From: Carl E. Love @ 2017-01-13 22:58 UTC (permalink / raw)
To: cel, gcc-patches, Bill Schmidt, David Edelsohn, Segher Boessenkool
GCC maintainers:
The following patch fixes an issue with the builtin test test_ne_long().
The issue is the arguments need to be "bool long long" not "bool long"
to get the correct 64-bit value when running in 32-bit mode.
The patch has been tested on:
powerpc64-unknown-linux-gnu (Power 7 64-bit, 32-bit) with no
regressions.
Is this OK for trunk?
Carl Love
--------------------------------------------------------------------------
gcc/testsuite/ChangeLog:
2017-01-13 Carl Love <cel@us.ibm.com>
* gcc.target/powerpc/builtins-3-p9.c (test_ne_long()):
Test fails in 32-bit mode because the arguments are of type
"bool long" not "bool long long". The arguments need to be
"bool long long" to get a correct 64-bit value in 32-bit mode.
---
gcc/testsuite/gcc.target/powerpc/builtins-3-p9.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/gcc/testsuite/gcc.target/powerpc/builtins-3-p9.c
b/gcc/testsuite/gcc.target/powerpc/builtins-3-p9.c
index d846e29..e3db2da 100644
--- a/gcc/testsuite/gcc.target/powerpc/builtins-3-p9.c
+++ b/gcc/testsuite/gcc.target/powerpc/builtins-3-p9.c
@@ -22,8 +22,8 @@ test_ne_int (vector bool int x, vector bool int y)
return vec_cmpne (x, y);
}
-vector bool long
-test_ne_long (vector bool long x, vector bool long y)
+vector bool long long
+test_ne_long (vector bool long long x, vector bool long long y)
{
return vec_cmpne (x, y);
}
--
1.8.3.1
^ permalink raw reply [flat|nested] 2+ messages in thread
* Re: [PATCH, rs6000] Fix for test_ne_int() built-in test case.
2017-01-13 22:58 [PATCH, rs6000] Fix for test_ne_int() built-in test case Carl E. Love
@ 2017-01-14 10:41 ` Segher Boessenkool
0 siblings, 0 replies; 2+ messages in thread
From: Segher Boessenkool @ 2017-01-14 10:41 UTC (permalink / raw)
To: Carl E. Love; +Cc: cel, gcc-patches, Bill Schmidt, David Edelsohn
On Fri, Jan 13, 2017 at 02:58:23PM -0800, Carl E. Love wrote:
> The following patch fixes an issue with the builtin test test_ne_long().
> The issue is the arguments need to be "bool long long" not "bool long"
> to get the correct 64-bit value when running in 32-bit mode.
>
> The patch has been tested on:
> powerpc64-unknown-linux-gnu (Power 7 64-bit, 32-bit) with no
> regressions.
>
> Is this OK for trunk?
> 2017-01-13 Carl Love <cel@us.ibm.com>
>
> * gcc.target/powerpc/builtins-3-p9.c (test_ne_long()):
> Test fails in 32-bit mode because the arguments are of type
> "bool long" not "bool long long". The arguments need to be
> "bool long long" to get a correct 64-bit value in 32-bit mode.
Just "Change argument and return types to bool long long."?
Okay for trunk with that (you didn't mention the return type before; the
rest is fine if overly verbose, a changelog entry does not usually say
"why", just "what").
Segher
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2017-01-14 10:41 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-01-13 22:58 [PATCH, rs6000] Fix for test_ne_int() built-in test case Carl E. Love
2017-01-14 10:41 ` Segher Boessenkool
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).