public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: Jakub Jelinek <jakub@redhat.com>
To: Alexandre Oliva <aoliva@redhat.com>
Cc: gcc-patches@gcc.gnu.org, jason@redhat.com, ccoutant@gmail.com
Subject: Re: [PR63238] output alignment debug information
Date: Wed, 01 Feb 2017 15:55:00 -0000	[thread overview]
Message-ID: <20170201155533.GK14051@tucnak> (raw)
In-Reply-To: <or37g5ggud.fsf@lxoliva.fsfla.org>

On Fri, Jan 27, 2017 at 04:24:58AM -0200, Alexandre Oliva wrote:
> Output DWARFv5+ DW_AT_alignment for non-default alignment of
> variables, fields and types.

The new tests all fail on targets that default to -gstrict-dwarf
because they have buggy or prehistoric linkers/debug info consumers
like Darwin.

Fixed thusly, tested on x86_64-linux vanilla and with common.opt
hack to turn -gstrict-dwarf and -fno-merge-debug-strings by default,
committed to trunk as obvious:

2017-02-01  Jakub Jelinek  <jakub@redhat.com>

	PR testsuite/79324
	* gcc.dg/debug/dwarf2/align-1.c: Add -gno-strict-dwarf to dg-options.
	* gcc.dg/debug/dwarf2/align-2.c: Likewise.
	* gcc.dg/debug/dwarf2/align-3.c: Likewise.
	* gcc.dg/debug/dwarf2/align-4.c: Likewise.
	* gcc.dg/debug/dwarf2/align-5.c: Likewise.
	* gcc.dg/debug/dwarf2/align-6.c: Likewise.
	* gcc.dg/debug/dwarf2/align-as-1.c: Likewise.
	* g++.dg/debug/dwarf2/align-1.C: Likewise.
	* g++.dg/debug/dwarf2/align-2.C: Likewise.
	* g++.dg/debug/dwarf2/align-3.C: Likewise.
	* g++.dg/debug/dwarf2/align-4.C: Likewise.
	* g++.dg/debug/dwarf2/align-5.C: Likewise.
	* g++.dg/debug/dwarf2/align-6.C: Likewise.

--- gcc/testsuite/gcc.dg/debug/dwarf2/align-1.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-1.c	2017-02-01 16:39:24.852112430 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 int __attribute__((__aligned__(64))) i;
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-2.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-2.c	2017-02-01 16:39:34.260991165 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 typedef int __attribute__((__aligned__(64))) i_t;
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-3.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-3.c	2017-02-01 16:39:37.841945013 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 typedef int int_t;
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-4.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-4.c	2017-02-01 16:39:41.889892842 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 2 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-5.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-5.c	2017-02-01 16:39:46.117838350 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-6.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-6.c	2017-02-01 16:39:50.884776913 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {
--- gcc/testsuite/gcc.dg/debug/dwarf2/align-as-1.c.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/gcc.dg/debug/dwarf2/align-as-1.c	2017-02-01 16:39:55.554716725 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 int _Alignas(64) i;
--- gcc/testsuite/g++.dg/debug/dwarf2/align-1.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-1.C	2017-02-01 16:40:58.421906472 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 int __attribute__((__aligned__(64))) i;
--- gcc/testsuite/g++.dg/debug/dwarf2/align-2.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-2.C	2017-02-01 16:41:01.340868851 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 typedef int __attribute__((__aligned__(64))) i_t;
--- gcc/testsuite/g++.dg/debug/dwarf2/align-3.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-3.C	2017-02-01 16:41:04.379829684 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 typedef int int_t;
--- gcc/testsuite/g++.dg/debug/dwarf2/align-4.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-4.C	2017-02-01 16:41:07.323791741 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 2 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {
--- gcc/testsuite/g++.dg/debug/dwarf2/align-5.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-5.C	2017-02-01 16:41:10.945745060 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {
--- gcc/testsuite/g++.dg/debug/dwarf2/align-6.C.jj	2017-01-31 09:26:00.000000000 +0100
+++ gcc/testsuite/g++.dg/debug/dwarf2/align-6.C	2017-02-01 16:41:14.330701434 +0100
@@ -1,5 +1,5 @@
 // { dg-do compile }
-// { dg-options "-O -g -dA" }
+// { dg-options "-O -g -dA -gno-strict-dwarf" }
 // { dg-final { scan-assembler-times " DW_AT_alignment" 1 { xfail { powerpc-ibm-aix* } } } }
 
 struct tt {


	Jakub

      parent reply	other threads:[~2017-02-01 15:55 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-08-27  4:48 Alexandre Oliva
2016-09-24  0:22 ` Alexandre Oliva
2016-10-19 10:15   ` Alexandre Oliva
2017-01-27  6:37     ` Alexandre Oliva
2017-01-29 18:55       ` Cary Coutant
2017-01-30 17:55         ` Alexandre Oliva
2017-03-17  3:13           ` Cary Coutant
2017-02-01 15:55       ` Jakub Jelinek [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170201155533.GK14051@tucnak \
    --to=jakub@redhat.com \
    --cc=aoliva@redhat.com \
    --cc=ccoutant@gmail.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=jason@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).