From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 31581 invoked by alias); 21 Feb 2017 21:07:16 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 31570 invoked by uid 89); 21 Feb 2017 21:07:15 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-2.0 required=5.0 tests=AWL,BAYES_00,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy=H*r:8.13.8 X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Tue, 21 Feb 2017 21:07:14 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v1LL71a2001743; Tue, 21 Feb 2017 15:07:01 -0600 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v1LL6xqZ001738; Tue, 21 Feb 2017 15:06:59 -0600 Date: Tue, 21 Feb 2017 21:23:00 -0000 From: Segher Boessenkool To: Michael Eager Cc: Jakub Jelinek , gcc-patches@gcc.gnu.org Subject: Re: [PATCH 3/6] microblaze: Fixes for RTL checking Message-ID: <20170221210657.GR21840@gate.crashing.org> References: <0b3332af5c3662c0efdf2d930c06457b0fd3cd13.1487685472.git.segher@kernel.crashing.org> <20170221201555.GW1849@tucnak> <58ACA485.4030105@eagercon.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <58ACA485.4030105@eagercon.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg01357.txt.bz2 On Tue, Feb 21, 2017 at 12:35:17PM -0800, Michael Eager wrote: > On 02/21/2017 12:15 PM, Jakub Jelinek wrote: > >On Tue, Feb 21, 2017 at 02:48:15PM +0000, Segher Boessenkool wrote: > >>- /* Shift by zero -- copy regs if necessary. */ > >>+ /* Shift by zero -- copy regs. */ > >> if ((GET_CODE (operands[2]) == CONST_INT) && (INTVAL (operands[2]) == > >> 0)) > > > >You could have changed this line to > > if (operands[2] == const0_rtx) > >as well. > > And this would not change the generated code. Of course, but you still need the other changes. I did not make this random cleanup because a) it is a random cleanup; and b) there are at least three occurrences of this in both microblaze.c and microblaze.md . Michael, will you make a fix yourself? --enable-checking=yes,rtl will reproduce the problem. Segher