From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 64019 invoked by alias); 24 Feb 2017 10:14:03 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 63998 invoked by uid 89); 24 Feb 2017 10:14:02 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=copy-prop, copyprop, VARYING, populates X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Fri, 24 Feb 2017 10:14:00 +0000 Received: from int-mx13.intmail.prod.int.phx2.redhat.com (int-mx13.intmail.prod.int.phx2.redhat.com [10.5.11.26]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 6FC3FC04BD55; Fri, 24 Feb 2017 10:13:59 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-76.ams2.redhat.com [10.36.117.76]) by int-mx13.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1OADvFS023544 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Fri, 24 Feb 2017 05:13:59 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v1OADtIf012953; Fri, 24 Feb 2017 11:13:55 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v1OADrP3007350; Fri, 24 Feb 2017 11:13:53 +0100 Date: Fri, 24 Feb 2017 10:22:00 -0000 From: Jakub Jelinek To: Richard Biener Cc: Martin Sebor , Gcc Patch List Subject: Re: enable -Wformat-truncation with -Og (PR 79691) Message-ID: <20170224101353.GJ1849@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg01489.txt.bz2 On Fri, Feb 24, 2017 at 11:10:51AM +0100, Richard Biener wrote: > On Fri, Feb 24, 2017 at 1:35 AM, Martin Sebor wrote: > > Bug 79691 - -Wformat-truncation suppressed by (and only by) -Og > > points out that the gimple-ssa-sprintf pass doesn't run when > > this optimization option is used. That's because I forgot to > > add it to the set of optimization passes that run with that > > option. The attached trivial patch tested on x86_64 corrects > > the oversight. > > > > Is this okay for 7.0? > > Any reason for the placement before copy-prop? I'd have done it > after pass_late_warn_uninitialized for example. > > Also doesn't pass_sprintf_length rely on get_range_info ()? With -Og > nothing populates those so you'll always get effectively VARYING ranges. -O0 and -O1 are the same case with that though. Jakub