From: Jakub Jelinek <jakub@redhat.com>
To: Volker Reichelt <v.reichelt@netcologne.de>
Cc: gcc-patches@gcc.gnu.org, Marek Polacek <polacek@redhat.com>
Subject: Re: [PATCH] Some more translation related tweaks
Date: Sun, 26 Feb 2017 13:25:00 -0000 [thread overview]
Message-ID: <20170226123555.GW1849@tucnak> (raw)
In-Reply-To: <tkrat.a7532927a533bdd5@netcologne.de>
On Sun, Feb 26, 2017 at 01:18:57PM +0100, Volker Reichelt wrote:
> 2017-02-26 Volker Reichelt <v.reichelt@netcologne.de>
>
> * init.c: Include intl.h
Missing .
> @@ -29,6 +29,7 @@
> #include "varasm.h"
> #include "gimplify.h"
> #include "c-family/c-ubsan.h"
> +#include "intl.h"
>
> static bool begin_init_stmts (tree *, tree *);
> static tree finish_init_stmts (bool, tree, tree);
> @@ -2805,11 +2806,11 @@
> {
> const char *msg;
> if (typedef_variant_p (orig_type))
> - msg = ("non-constant array new length must be specified "
> - "directly, not by typedef");
> + msg = G_("non-constant array new length must be specified "
> + "directly, not by typedef");
> else
> - msg = ("non-constant array new length must be specified "
> - "without parentheses around the type-id");
> + msg = G_("non-constant array new length must be specified "
> + "without parentheses around the type-id");
> pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location),
> OPT_Wvla, msg);
This is not -Wformat-security friendly, perhaps better
pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla,
typedef_variant_p (orig_type)
? "non-constant array new length must be specified "
"directly, not by typedef"
: "non-constant array new length must be specified "
"without parentheses around the type-id");
?
> }
> Index: gcc/cp/pt.c
> ===================================================================
> --- gcc/cp/pt.c (revision 245719)
> +++ gcc/cp/pt.c (working copy)
> @@ -17190,10 +17190,11 @@
> stricter. */
> bool in_lambda = (current_class_type
> && LAMBDA_TYPE_P (current_class_type));
> - char const *msg = "%qD was not declared in this scope, "
> - "and no declarations were found by "
> - "argument-dependent lookup at the point "
> - "of instantiation";
> + char const *const msg =
= should go on the next line in this case, i.e.
= G_("%qD was not declared in this scope, "
Jakub
next prev parent reply other threads:[~2017-02-26 12:36 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 12:36 Volker Reichelt
2017-02-26 13:25 ` Jakub Jelinek [this message]
2017-02-27 10:27 ` Volker Reichelt
2017-02-27 11:15 ` Jakub Jelinek
2017-02-27 12:49 ` Joseph Myers
2017-02-27 19:23 ` Jakub Jelinek
2017-02-27 22:27 ` Joseph Myers
2017-03-01 10:20 ` Tom de Vries
2017-03-01 11:14 ` Jakub Jelinek
2017-02-27 13:33 ` Jakub Jelinek
2017-02-27 13:40 ` Volker Reichelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170226123555.GW1849@tucnak \
--to=jakub@redhat.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=polacek@redhat.com \
--cc=v.reichelt@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).