From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54155 invoked by alias); 26 Feb 2017 12:36:04 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54143 invoked by uid 89); 26 Feb 2017 12:36:03 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-5.9 required=5.0 tests=BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD,SPAM_BODY,SPF_HELO_PASS autolearn=ham version=3.3.2 spammy=H*MI:sk:tkrat.a, H*f:sk:tkrat.a, HX-Greylist:Sun, H*i:sk:tkrat.a X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Sun, 26 Feb 2017 12:36:02 +0000 Received: from int-mx14.intmail.prod.int.phx2.redhat.com (int-mx14.intmail.prod.int.phx2.redhat.com [10.5.11.27]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 53FA2C054C21; Sun, 26 Feb 2017 12:36:02 +0000 (UTC) Received: from tucnak.zalov.cz (ovpn-117-76.ams2.redhat.com [10.36.117.76]) by int-mx14.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id v1QCa01c029696 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=NO); Sun, 26 Feb 2017 07:36:01 -0500 Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v1QCZvXs014981; Sun, 26 Feb 2017 13:35:57 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v1QCZtAA014980; Sun, 26 Feb 2017 13:35:55 +0100 Date: Sun, 26 Feb 2017 13:25:00 -0000 From: Jakub Jelinek To: Volker Reichelt Cc: gcc-patches@gcc.gnu.org, Marek Polacek Subject: Re: [PATCH] Some more translation related tweaks Message-ID: <20170226123555.GW1849@tucnak> Reply-To: Jakub Jelinek References: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-02/txt/msg01574.txt.bz2 On Sun, Feb 26, 2017 at 01:18:57PM +0100, Volker Reichelt wrote: > 2017-02-26 Volker Reichelt > > * init.c: Include intl.h Missing . > @@ -29,6 +29,7 @@ > #include "varasm.h" > #include "gimplify.h" > #include "c-family/c-ubsan.h" > +#include "intl.h" > > static bool begin_init_stmts (tree *, tree *); > static tree finish_init_stmts (bool, tree, tree); > @@ -2805,11 +2806,11 @@ > { > const char *msg; > if (typedef_variant_p (orig_type)) > - msg = ("non-constant array new length must be specified " > - "directly, not by typedef"); > + msg = G_("non-constant array new length must be specified " > + "directly, not by typedef"); > else > - msg = ("non-constant array new length must be specified " > - "without parentheses around the type-id"); > + msg = G_("non-constant array new length must be specified " > + "without parentheses around the type-id"); > pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), > OPT_Wvla, msg); This is not -Wformat-security friendly, perhaps better pedwarn (EXPR_LOC_OR_LOC (outer_nelts, input_location), OPT_Wvla, typedef_variant_p (orig_type) ? "non-constant array new length must be specified " "directly, not by typedef" : "non-constant array new length must be specified " "without parentheses around the type-id"); ? > } > Index: gcc/cp/pt.c > =================================================================== > --- gcc/cp/pt.c (revision 245719) > +++ gcc/cp/pt.c (working copy) > @@ -17190,10 +17190,11 @@ > stricter. */ > bool in_lambda = (current_class_type > && LAMBDA_TYPE_P (current_class_type)); > - char const *msg = "%qD was not declared in this scope, " > - "and no declarations were found by " > - "argument-dependent lookup at the point " > - "of instantiation"; > + char const *const msg = = should go on the next line in this case, i.e. = G_("%qD was not declared in this scope, " Jakub