From: Jakub Jelinek <jakub@redhat.com>
To: Tom de Vries <Tom_deVries@mentor.com>
Cc: Joseph Myers <joseph@codesourcery.com>,
Volker Reichelt <v.reichelt@netcologne.de>,
gcc-patches@gcc.gnu.org,
Marek Polacek <polacek@redhat.com>
Subject: Re: [PATCH] Some more translation related tweaks
Date: Wed, 01 Mar 2017 11:14:00 -0000 [thread overview]
Message-ID: <20170301111423.GB1849@tucnak> (raw)
In-Reply-To: <36ea892d-a12e-f61e-18cd-8e7ca00c8629@mentor.com>
On Wed, Mar 01, 2017 at 11:20:37AM +0100, Tom de Vries wrote:
> > 2017-02-27 Jakub Jelinek <jakub@redhat.com>
> >
> > * config/i386/i386.c (ix86_option_override_internal): Use
> > cond ? G_("...") : G_("...") instead of just cond ? "..." : "...".
> > * config/nvptx/nvptx.c (nvptx_goacc_validate_dims): Likewise.
>
> > --- gcc/config/nvptx/nvptx.c.jj 2017-02-21 15:36:03.000000000 +0100
> > +++ gcc/config/nvptx/nvptx.c 2017-02-27 15:48:20.031688240 +0100
> > @@ -4542,8 +4542,8 @@ nvptx_goacc_validate_dims (tree decl, in
> > if (fn_level < 0 && dims[GOMP_DIM_VECTOR] >= 0)
> > warning_at (decl ? DECL_SOURCE_LOCATION (decl) : UNKNOWN_LOCATION, 0,
> > dims[GOMP_DIM_VECTOR]
> > - ? "using vector_length (%d), ignoring %d"
> > - : "using vector_length (%d), ignoring runtime setting",
> > + ? G_("using vector_length (%d), ignoring %d")
> > + : G_("using vector_length (%d), ignoring runtime setting"),
> > PTX_VECTOR_LENGTH, dims[GOMP_DIM_VECTOR]);
> > dims[GOMP_DIM_VECTOR] = PTX_VECTOR_LENGTH;
> > changed = true;
>
> This breaks the nvptx build:
> ...
> src/gcc-mainline/gcc/config/nvptx/nvptx.c: In function 'bool
> nvptx_goacc_validate_dims(tree, int*, int)':
> src/gcc-mainline/gcc/config/nvptx/nvptx.c:4545:51: error: 'G_' was not
> declared in this scope
> ...
Oops, sorry, I've fixed it in i386.c and two other files, but missed
nvptx.c. Fixed thusly, committed to trunk:
2017-03-01 Jakub Jelinek <jakub@redhat.com>
* config/nvptx/nvptx.c: Include intl.h.
--- gcc/config/nvptx/nvptx.c.jj 2017-02-28 16:24:05.000000000 +0100
+++ gcc/config/nvptx/nvptx.c 2017-03-01 11:24:04.178802355 +0100
@@ -69,6 +69,7 @@
#include "tree-phinodes.h"
#include "cfgloop.h"
#include "fold-const.h"
+#include "intl.h"
/* This file should be included last. */
#include "target-def.h"
Jakub
next prev parent reply other threads:[~2017-03-01 11:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-02-26 12:36 Volker Reichelt
2017-02-26 13:25 ` Jakub Jelinek
2017-02-27 10:27 ` Volker Reichelt
2017-02-27 11:15 ` Jakub Jelinek
2017-02-27 12:49 ` Joseph Myers
2017-02-27 19:23 ` Jakub Jelinek
2017-02-27 22:27 ` Joseph Myers
2017-03-01 10:20 ` Tom de Vries
2017-03-01 11:14 ` Jakub Jelinek [this message]
2017-02-27 13:33 ` Jakub Jelinek
2017-02-27 13:40 ` Volker Reichelt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170301111423.GB1849@tucnak \
--to=jakub@redhat.com \
--cc=Tom_deVries@mentor.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=joseph@codesourcery.com \
--cc=polacek@redhat.com \
--cc=v.reichelt@netcologne.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).