public inbox for gcc-patches@gcc.gnu.org
 help / color / mirror / Atom feed
From: James Greenhalgh <james.greenhalgh@arm.com>
To: "Hurugalawadi, Naveen" <Naveen.Hurugalawadi@cavium.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>,
	"Pinski, Andrew"	<Andrew.Pinski@cavium.com>,
	Marcus Shawcroft <marcus.shawcroft@arm.com>,
	Richard Earnshaw <Richard.Earnshaw@arm.com>, <nd@arm.com>
Subject: Re: [PATCH][AArch64] Add crypto_pmull attribute
Date: Thu, 09 Mar 2017 10:51:00 -0000	[thread overview]
Message-ID: <20170309105108.GA40548@arm.com> (raw)
In-Reply-To: <CO2PR07MB2694DCE16B83432F033B76F7832C0@CO2PR07MB2694.namprd07.prod.outlook.com>

On Mon, Mar 06, 2017 at 05:09:34AM +0000, Hurugalawadi, Naveen wrote:
> Hi,
> 
> Please find attached the patch that adds "crypto_pmull" for AArch64.
> 
> Bootstrapped and Regression tested on aarch64-thunder-linux.
> 
> Please review the patch and let us know if its okay for Stage-1?
> 
> Thanks,
> Naveen
> 
> 2017-03-06  Julian Brown  <julian@codesourcery.com>
> 	    Naveen H.S  <Naveen.Hurugalawadi@cavium.com>
> 
> 	* config/aarch64/aarch64-simd.md (aarch64_crypto_pmulldi)
> 	(aarch64_crypto_pmullv2di): Change type attribute to crypto_pmull.
> 	* config/aarch64/thunderx2t99.md (thunderx2t99_pmull): New
> 	reservation.
> 	* config/arm/cortex-a57.md (cortex_a57_neon_type): Add crypto_pmull to
> 	attribute type list for neon_multiply.

You need to do this for all cores which might be affected by this change,
i.e. all those which model neon_mul_d_long.

I see:

  gcc/config/arm/cortex-a53.md
  gcc/config/arm/exynos-m1.md 

Which your patch doesn't touch, but which have modeling for neon_mul_d_long.

Thanks,
James



> 	* config/arm/crypto.md (crypto_vmullp64): Change type to crypto_pmull.
> 	* config/arm/types.md (crypto_pmull): Add.
> 	* config/arm/xgene1.md (xgene1_neon_pmull): Add crypto_pmull to
> 	attribute type list.

  reply	other threads:[~2017-03-09 10:51 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-03-06  5:11 Hurugalawadi, Naveen
2017-03-09 10:51 ` James Greenhalgh [this message]
2017-03-10  6:37   ` Hurugalawadi, Naveen
2017-04-25  7:10     ` [PING][PATCH][AArch64] " Hurugalawadi, Naveen
2017-05-11  4:52       ` [PING2][PATCH][AArch64] " Hurugalawadi, Naveen
2017-05-26  6:26         ` [PING 3][PATCH][AArch64] " Hurugalawadi, Naveen
2017-06-06 13:29     ` [PATCH][AArch64] " James Greenhalgh
2017-06-20  9:27       ` Hurugalawadi, Naveen
2017-06-20  9:41         ` Ramana Radhakrishnan
2017-06-21  5:55           ` Hurugalawadi, Naveen

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20170309105108.GA40548@arm.com \
    --to=james.greenhalgh@arm.com \
    --cc=Andrew.Pinski@cavium.com \
    --cc=Naveen.Hurugalawadi@cavium.com \
    --cc=Richard.Earnshaw@arm.com \
    --cc=gcc-patches@gcc.gnu.org \
    --cc=marcus.shawcroft@arm.com \
    --cc=nd@arm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).