From: Jonathan Wakely <jwakely@redhat.com>
To: David Edelsohn <dje.gcc@gmail.com>
Cc: "libstdc++@gcc.gnu.org" <libstdc++@gcc.gnu.org>,
GCC Patches <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] PR libstdc++/79789 fix non-reserved names in headers
Date: Tue, 14 Mar 2017 23:14:00 -0000 [thread overview]
Message-ID: <20170314231429.GD3501@redhat.com> (raw)
In-Reply-To: <20170310152017.GR3501@redhat.com>
On 10/03/17 15:20 +0000, Jonathan Wakely wrote:
>On 09/03/17 19:46 +0000, Jonathan Wakely wrote:
>>On 03/03/17 10:47 -0500, David Edelsohn wrote:
>>>This patch caused a new regression on AIX.
>>
>>I'm unable to bootstrap on either gcc111 or gcc119 so I can't test
>>the fix.
>
>export CONFIG_SHELL=/usr/bin/bash
>PATH=/opt/freeware/bin:$PATH
>$gccsrcdir/configure ... --disable-werror --with-included-gettext --with-gmp=/opt/cfarm --with-libiconv-prefix=/opt/cfarm --disable-libstdcxx-pch
>
>Here's what I'm committing to trunk.
>
>Tested powerpc64le-linux and powerpc-ibm-aix7.2.0.0
Also committed to gcc-5-branch and gcc-6-branch.
>commit 5e390a2874a9629c13eaddb76f82a66f0634a864
>Author: Jonathan Wakely <jwakely@redhat.com>
>Date: Fri Mar 10 13:14:33 2017 +0000
>
> Fix libstdc++ reserved names test to pass on AIX
>
> * testsuite/17_intro/names.cc: Undefine macros that clash with
> identifiers in AIX system headers.
>
>diff --git a/libstdc++-v3/testsuite/17_intro/names.cc b/libstdc++-v3/testsuite/17_intro/names.cc
>index a7d9a6b..c525861 100644
>--- a/libstdc++-v3/testsuite/17_intro/names.cc
>+++ b/libstdc++-v3/testsuite/17_intro/names.cc
>@@ -98,4 +98,13 @@
> #define x (
> #define y (
> #define z (
>+
>+#ifdef _AIX
>+// See https://gcc.gnu.org/ml/libstdc++/2017-03/msg00015.html
>+#undef f
>+#undef r
>+#undef x
>+#undef y
>+#endif
>+
> #include <bits/stdc++.h>
next prev parent reply other threads:[~2017-03-14 23:14 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-03-03 15:47 David Edelsohn
2017-03-07 12:26 ` Jonathan Wakely
2017-03-09 19:46 ` Jonathan Wakely
2017-03-10 15:20 ` Jonathan Wakely
2017-03-10 16:11 ` David Edelsohn
2017-03-14 23:14 ` Jonathan Wakely [this message]
-- strict thread matches above, loose matches on Subject: below --
2017-03-02 5:25 Jonathan Wakely
2017-03-02 18:59 ` Jonathan Wakely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170314231429.GD3501@redhat.com \
--to=jwakely@redhat.com \
--cc=dje.gcc@gmail.com \
--cc=gcc-patches@gcc.gnu.org \
--cc=libstdc++@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).