From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 54849 invoked by alias); 20 Mar 2017 18:43:56 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 54713 invoked by uid 89); 20 Mar 2017 18:43:55 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-11.0 required=5.0 tests=AWL,BAYES_00,GIT_PATCH_2,GIT_PATCH_3,RP_MATCHES_RCVD autolearn=ham version=3.3.2 spammy= X-Spam-User: qpsmtpd, 2 recipients X-HELO: gate.crashing.org Received: from gate.crashing.org (HELO gate.crashing.org) (63.228.1.57) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Mon, 20 Mar 2017 18:43:54 +0000 Received: from gate.crashing.org (localhost.localdomain [127.0.0.1]) by gate.crashing.org (8.14.1/8.13.8) with ESMTP id v2KIhetM002406; Mon, 20 Mar 2017 13:43:42 -0500 Received: (from segher@localhost) by gate.crashing.org (8.14.1/8.14.1/Submit) id v2KIhb2D002385; Mon, 20 Mar 2017 13:43:39 -0500 Date: Mon, 20 Mar 2017 18:43:00 -0000 From: Segher Boessenkool To: Aaron Sawdey Cc: gcc-patches@gcc.gnu.org, Bill Schmidt , meissner@gcc.gnu.org, dje.gcc@gmail.com Subject: Re: [PATCH][PR target/80083][7 regression] fix power9 vsx-small-integer issue caused by wrong constraints Message-ID: <20170320184332.GE4402@gate.crashing.org> References: <1490026293.5885.6.camel@linux.vnet.ibm.com> <1490033115.5885.8.camel@linux.vnet.ibm.com> Mime-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1490033115.5885.8.camel@linux.vnet.ibm.com> User-Agent: Mutt/1.4.2.3i X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01043.txt.bz2 On Mon, Mar 20, 2017 at 01:05:15PM -0500, Aaron Sawdey wrote: > > 2017-03-20  Aaron Sawdey   > > > > PR target/80083 > > * config/rs6000/rs6000.md (*movsi_internal1): incorrect > > constraints > > for alternatives 14/15. A changelog line should describe what is changed, not what was wrong; it should start with a capital; and you changed alternatives 13 and 14 (they start counting at 0). > --- gcc/config/rs6000/rs6000.md (revision 246224) > +++ gcc/config/rs6000/rs6000.md (working copy) > @@ -6727,7 +6727,7 @@ > [(set (match_operand:SI 0 "rs6000_nonimmediate_operand" > "=r, r, r, ?*wI, ?*wH, > m, ?Z, ?Z, r, r, > - r, ?*wIwH, ?*wJwK, ?*wK, ?*wJwK, > + r, ?*wIwH, ?*wJwK, ?*wJwK, ?*wu, > ?*wJwK, ?*wH, ?*wK, ?*wIwH, ?r, > r, *c*l, *h, *h") The change to alt 13 is obvious enough. Could you explain alt 14 a bit more though? It used to allow more than it does after this patch; are those handled by other alternatives? Segher