From: Jakub Jelinek <jakub@redhat.com>
To: Cesar Philippidis <cesar@codesourcery.com>
Cc: "gcc-patches@gcc.gnu.org" <gcc-patches@gcc.gnu.org>
Subject: Re: [PATCH] Fix PR80029
Date: Wed, 22 Mar 2017 13:43:00 -0000 [thread overview]
Message-ID: <20170322134249.GE11094@tucnak> (raw)
In-Reply-To: <278ce4b7-cc02-453b-10fc-8094e9078d9a@codesourcery.com>
On Wed, Mar 22, 2017 at 06:40:03AM -0700, Cesar Philippidis wrote:
> In addition to resolving the memory leak involving OpenACC delare
> clauses, this patch also corrects an ICE involving VLA variables as data
> clause arguments used in acc declare constructs. More details can be
> found here <https://gcc.gnu.org/ml/gcc-patches/2016-09/msg01630.html>.
>
> Is this OK for trunk?
>
> Cesar
> 2017-03-22 Cesar Philippidis <cesar@codesourcery.com>
>
> PR c++/80029
>
> gcc/
> * gimplify.c (is_oacc_declared): New function.
> (oacc_default_clause): Use it to set default flags for acc declared
> variables inside parallel regions.
> (gimplify_scan_omp_clauses): Strip firstprivate pointers for acc
> declared variables.
> (gimplify_oacc_declare): Gimplify the declare clauses. Add the
> declare attribute to any decl as necessary.
>
> libgomp/
> * testsuite/libgomp.oacc-c-c++-common/declare-vla.c: New test.
Ok if testing passed.
Jakub
next prev parent reply other threads:[~2017-03-22 13:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-22 23:39 [openacc] fix an ICE with acc declared VLAs Cesar Philippidis
2016-09-23 15:19 ` [gomp4] " Cesar Philippidis
2017-03-22 13:40 ` [PATCH] Fix PR80029 Cesar Philippidis
2017-03-22 13:43 ` Jakub Jelinek [this message]
2017-03-22 13:48 ` Cesar Philippidis
2017-03-22 13:50 ` Jakub Jelinek
2017-04-07 9:53 ` Thomas Schwinge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20170322134249.GE11094@tucnak \
--to=jakub@redhat.com \
--cc=cesar@codesourcery.com \
--cc=gcc-patches@gcc.gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).