From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (qmail 60194 invoked by alias); 22 Mar 2017 13:43:02 -0000 Mailing-List: contact gcc-patches-help@gcc.gnu.org; run by ezmlm Precedence: bulk List-Id: List-Archive: List-Post: List-Help: Sender: gcc-patches-owner@gcc.gnu.org Received: (qmail 60179 invoked by uid 89); 22 Mar 2017 13:43:01 -0000 Authentication-Results: sourceware.org; auth=none X-Virus-Found: No X-Spam-SWARE-Status: No, score=-1.9 required=5.0 tests=BAYES_00,RP_MATCHES_RCVD,SPF_HELO_PASS,URIBL_RED autolearn=ham version=3.3.2 spammy=HTo:U*cesar X-HELO: mx1.redhat.com Received: from mx1.redhat.com (HELO mx1.redhat.com) (209.132.183.28) by sourceware.org (qpsmtpd/0.93/v0.84-503-g423c35a) with ESMTP; Wed, 22 Mar 2017 13:43:00 +0000 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 30BB619D22F; Wed, 22 Mar 2017 13:43:01 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 30BB619D22F Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx05.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=jakub@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 30BB619D22F Received: from tucnak.zalov.cz (ovpn-116-72.ams2.redhat.com [10.36.116.72]) by smtp.corp.redhat.com (Postfix) with ESMTPS id CC6B97EFE4; Wed, 22 Mar 2017 13:43:00 +0000 (UTC) Received: from tucnak.zalov.cz (localhost [127.0.0.1]) by tucnak.zalov.cz (8.15.2/8.15.2) with ESMTP id v2MDgpfm008738; Wed, 22 Mar 2017 14:42:52 +0100 Received: (from jakub@localhost) by tucnak.zalov.cz (8.15.2/8.15.2/Submit) id v2MDgnms008736; Wed, 22 Mar 2017 14:42:49 +0100 Date: Wed, 22 Mar 2017 13:43:00 -0000 From: Jakub Jelinek To: Cesar Philippidis Cc: "gcc-patches@gcc.gnu.org" Subject: Re: [PATCH] Fix PR80029 Message-ID: <20170322134249.GE11094@tucnak> Reply-To: Jakub Jelinek References: <278ce4b7-cc02-453b-10fc-8094e9078d9a@codesourcery.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <278ce4b7-cc02-453b-10fc-8094e9078d9a@codesourcery.com> User-Agent: Mutt/1.7.1 (2016-10-04) X-IsSubscribed: yes X-SW-Source: 2017-03/txt/msg01162.txt.bz2 On Wed, Mar 22, 2017 at 06:40:03AM -0700, Cesar Philippidis wrote: > In addition to resolving the memory leak involving OpenACC delare > clauses, this patch also corrects an ICE involving VLA variables as data > clause arguments used in acc declare constructs. More details can be > found here . > > Is this OK for trunk? > > Cesar > 2017-03-22 Cesar Philippidis > > PR c++/80029 > > gcc/ > * gimplify.c (is_oacc_declared): New function. > (oacc_default_clause): Use it to set default flags for acc declared > variables inside parallel regions. > (gimplify_scan_omp_clauses): Strip firstprivate pointers for acc > declared variables. > (gimplify_oacc_declare): Gimplify the declare clauses. Add the > declare attribute to any decl as necessary. > > libgomp/ > * testsuite/libgomp.oacc-c-c++-common/declare-vla.c: New test. Ok if testing passed. Jakub